chore(deps): pin nodedb-client/types to the NodeDB git repo by rev - #6
Open
laksamanakeris wants to merge 1 commit into
Open
chore(deps): pin nodedb-client/types to the NodeDB git repo by rev#6laksamanakeris wants to merge 1 commit into
laksamanakeris wants to merge 1 commit into
Conversation
The published crates sit at 0.4.0 while the repo head is at 0.5.0 with hundreds of commits between them, including the fix that makes typed error classification reach the client instead of every server error arriving as a generic internal error. Waiting on a crates.io publish blocks that; pinning the repo does not. Pinned to fda34193, the repo head at the time of writing. Both crates pin the same commit, never a branch, so every CI run builds the same upstream code. The repo is public, so CI fetches it without credentials. The client's native feature stays off: the seam makes no client calls yet, and that feature pulls in a TLS and C-toolchain build tree that should land with the change that needs it. No source changes. Only services/error.rs touches client types, and it compiles unchanged. Transitively this moves zerompk from crates.io 0.6 to the git rev the client depends on. AGENTS.md setup section rewritten to match: the old text said the crates were unpublished and required a local patch, which is no longer the default path. The local-patch override stays documented, keyed on the git source rather than crates.io.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
nodedb-client/nodedb-typesfrom crates.io0.4.0to theNodeDB-Lab/nodedbgit repo, pinned by commit.Why
The published crates sit at 0.4.0 while the repo head is at 0.5.0, hundreds of commits apart. That gap includes the change that makes typed error classification reach the client: at 0.4.0 every server-returned error arrives as a generic internal error with
is_retriable() == false, so a database client cannot tell a typo from an outage and can never offer a retry. Waiting on a crates.io publish blocks that; pinning the repo does not.Mechanics
fda34193, the repo head at the time of writing. Both crates pin the same commit, never a branch, so every CI run builds identical upstream code.nativefeature stays off. The seam makes no client calls yet, and that feature pulls in a TLS and C-toolchain build tree (tokio-rustls,aws-lc-rs,cmake); the cost should land with the change that needs it.zerompkmoves from crates.io 0.6 to the git rev the client depends on.No source changes
Only
services/error.rstouches client types, and it compiles unchanged against the new rev.AGENTS.md's setup section is rewritten to match: the previous text said the crates were unpublished and required a local path patch, which is no longer the default path. The local-patch override stays documented, keyed on the git source.Verification
Resolved with no
.cargo/config.tomlpresent, i.e. exactly as CI will resolve it.Relationship to #5
Independent. This branches from
main; #5 is the seam work and does not depend on the client version. Either can merge first. If #5 merges first, this rebases cleanly (it touches onlyCargo.toml,Cargo.lock,AGENTS.md).