Skip to content

Fix frontend vite config#5680

Open
toviszsolt wants to merge 6 commits into
NginxProxyManager:developfrom
toviszsolt:fix-frontend-vite-config
Open

Fix frontend vite config#5680
toviszsolt wants to merge 6 commits into
NginxProxyManager:developfrom
toviszsolt:fix-frontend-vite-config

Conversation

@toviszsolt

Copy link
Copy Markdown
Contributor

Why

Use { shell: true } for execFile because yarn is often a shell script or a batch file (especially on Windows), and execFile requires a direct executable path unless a shell is provided to interpret the command.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • API changes
  • Performance improvement
  • Test addition or update

AI Usage

  • AI was used to write this
  • AI was used to review this

Copilot AI review requested due to automatic review settings June 26, 2026 04:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the frontend Vite dev-server startup hook that runs locale-related Yarn scripts, aiming to improve cross-platform (especially Windows) behavior when invoking yarn via Node’s execFile.

Changes:

  • Run yarn locale-compile and yarn locale-sort using execFile with shell execution enabled.
  • Normalize plugin name quoting to match the file’s double-quote style.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/vite.config.ts Outdated
Comment thread frontend/vite.config.ts Outdated
toviszsolt and others added 3 commits June 26, 2026 06:09
`{ shell: true }` is broader than needed and increases shell injection/quoting risk. Prefer making shell conditional (or using yarn.cmd on Windows) so non-Windows platforms keep the safer direct-exec behavior.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
`{ shell: true }` is broader than needed and increases shell injection/quoting risk. Prefer making shell conditional (or using yarn.cmd on Windows) so non-Windows platforms keep the safer direct-exec behavior.

@toviszsolt toviszsolt left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR resolves the issue of running execFile Yarn scripts on the Windows platform for the Vite dev server.

@nginxproxymanagerci

Copy link
Copy Markdown

Docker Image for build 2 is available on DockerHub:

nginxproxymanager/nginx-proxy-manager-dev:pr-5680

Note

Ensure you backup your NPM instance before testing this image! Especially if there are database changes.
This is a different docker image namespace than the official image.

Warning

Changes and additions to DNS Providers require verification by at least 2 members of the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants