Skip to content

ipv6nd: a zero Router Lifetime must not expire Route Information routes #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akiernan wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −0
Open

ipv6nd: a zero Router Lifetime must not expire Route Information routes #729

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ffa9c8
ipv6nd: rebuild routes when a Route Information route expires
akiernan Sep 13, 2026
0d7fcc1
ipv6nd: a zero Router Lifetime must not expire Route Information routes
akiernan Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/ipv6nd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1851,7 +1851,15 @@ ipv6nd_expirera(void *arg)
rap->iface->name, rinfo->sprefix);
TAILQ_REMOVE(&rap->rinfos, rinfo, next);
free(rinfo);
expired = true;
continue;

@rsmarples rsmarples Sep 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to set expired = true here so that rt_build() is called below.

@akiernan akiernan Sep 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something that's existing behaviour that is missing that? Happy to pick it up at the same time.

}

/* A non expired route information option keeps the RA valid. */
valid = true;
if (ltime != ND6_INFINITE_LIFETIME &&
(next == 0 || ltime < next))
next = ltime;
}

/* Work out expiry for ND options */
Expand Down