Support snapshot layouts for other clients and validate Engine API responses - #33
Merged
Merged
Conversation
8 of 16 tasks
kamilchodola
marked this pull request as ready for review
September 14, 2026 07:55
kamilchodola
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other clients can require snapshot contents to be mounted below the data-directory root. Add a constrained
snapshot_mount_pathoption for those layouts while preserving the existing default.EXPB previously checked HTTP 200 only. Parse both Engine API responses and require
VALID, with bounded error diagnostics and K6 thresholds that fail rejected or syncing replays.Validation: 52 unit tests passed with six live-network tests deselected. CI passed pytest, Ruff and ty.
The baseline and other clients passed smoke tests and three 1,000-block Fusaka replays each, with VALID-response thresholds, complete timing coverage, and clean logs and shutdown. Actions evidence: baseline, other clients, run set 1, and other clients, run set 2. The benchmarked revision has identical production code to this PR head; only test typing was subsequently fixed.