Fix benchmark teardown and allow snapshot-aligned starts - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXPB kept the payload server's SSE connection open while stopping Nethermind. Stop K6, the payload server, and Alloy before shutting down the execution client, while preserving log capture and profiler finalization. An ARM smoke run reduced post-workload cleanup from about 65.6 seconds to 5.7 seconds and retained normal Nethermind shutdown.
Add an optional, validated
EXPB_SKIP_OVERRIDEfor corpora containing entries older than the available snapshot state. This allows callers to align the first payload with the snapshot without changing the runner's source configuration or suppressing runtime exceptions. Defaults are unchanged.Validation: 53 unit tests passed (6 integration tests deselected), Ruff passed, and an ARM live teardown check passed with 1,000 payloads and no exceptions or invalid blocks. Full sequential-workflow calibration on both architectures is in progress.