chore(deps): drop redundant version pins managed by parent BOMs - #142
Open
TaurMorchant wants to merge 1 commit into
Open
chore(deps): drop redundant version pins managed by parent BOMs#142TaurMorchant wants to merge 1 commit into
TaurMorchant wants to merge 1 commit into
Conversation
alsergs
approved these changes
Jul 15, 2026
TaurMorchant
force-pushed
the
chore/clean-up-internal-boms
branch
from
August 10, 2026 12:06
f915741 to
b338535
Compare
Several third-party versions were pinned twice: once in one of our BOMs and once in the BOM that one imports. Remove the duplicates so each library has a single source of truth: - commons-dbcp2, jedis, httpcore5, freemarker, HikariCP: managed by spring-boot-dependencies via core-spring-internal-bom - wagon-provider-api: managed by quarkus-bom via core-quarkus-internal-bom httpclient5 keeps its pin in core-internal-bom, at the version it already had. quarkus-bom manages the HttpComponents 4.x line only and never provides a version for httpclient5, while the Quarkus extension dbaas-opensearch-client compiles against it through dbaas-client-opensearch-base. Dropping the pin would leave that version unmanaged in the Quarkus reactor. Consumers now import the internal BOMs at 1.1.0-SNAPSHOT instead of the released 1.0.3. The reactor then builds the BOMs it consumes, so CI exercises BOM changes in the same build rather than only after a release. Also fix a typo in a micrometer property name in cloud-core-java-bom (io.micrometer.verion -> io.micrometer.version). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
TaurMorchant
force-pushed
the
chore/clean-up-internal-boms
branch
from
August 10, 2026 13:01
b338535 to
f913805
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove third-party version pins that merely duplicated versions already provided by the managing BOMs, giving each library a single source of truth:
httpcore5, httpclient5, commons-dbcp2, jedis, freemarker, HikariCP: managed byspring-boot-dependenciesviacore-spring-internal-bomwagon-provider-api: managed byquarkus-bomviacore-quarkus-internal-bom, and not referenced by any moduleAlso fix a typo in the micrometer version property name (
io.micrometer.verion->io.micrometer.version) incloud-core-java-bom.