Repository navigation
Conversation
Co-authored-by: kwin <185025+kwin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with permissions for the 'everyone' principal
Preserve existing ACLs for the everyone principal
Sep 30, 2026
Member
|
@ghenzler WDYT? Not sure whether like this or rather bail out in case no |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Repository-level ACEs remain vulnerable because null paths bypass the unmanaged-path regex.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Protects existing everyone ACLs from reconciliation cleanup by default.
Changes:
- Defaults
everyone’s unmanaged path regex to.*. - Adds regression coverage and documents opt-in path management.
| File | Description |
|---|---|
AuthorizablesConfig.java |
Applies the default protection. |
AuthorizablesConfigTest.java |
Tests content-path preservation. |
AdvancedFeatures.md |
Documents the new default. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+36
to
+38
| if (StringUtils.equals(configBean.getPrincipalName(), Constants.PRINCIPAL_EVERYONE) | ||
| && StringUtils.isEmpty(configBean.getUnmanagedAcePathsRegex())) { | ||
| configBean.setUnmanagedAcePathsRegex(".*"); |
Member
|
Actually this is already evaluated via #535 which prevents clearing permissions for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
everyoneis listed in YAML without an unmanaged-path rule, ACL reconciliation can remove its existing ACEs. This can revoke access to resources such as the login page.unmanagedAcePathsRegex: .*toeveryonewhen no per-principal regex is configured, excluding its ACLs from cleanup.The regex above is applied by default when omitted.