Repository navigation
Improve Captcha Post Error Handling - #39
Merged
Merged
Conversation
whiteh
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes response handling when captcha validation fails, and adds protector API status and latency to ingest records.
Changes
Captcha validation (
handleCaptcha)200first, and nginx loggedattempt to set status ... via ngx.exit after sending out the response status 200.502instead of an unhandled Lua error.2xxand4xxresponses are passed through with theirContent-Type. Any other status returns a generic502.Ingest
ProtectorStatus: the HTTP status returned by the protector API, or0if no response was received. The field is omitted when no protector call was made.ProtectorLatencyMs: how long the protector API call took, in milliseconds.BytesReceivednow uses$request_lengthand is always a number. It was always0before, because$bytes_receivedonly exists in nginx'sstreammodule.