Skip to content

Fix ticket action locking scope in web UI #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Neokil merged 2 commits into from
Jun 9, 2026
Merged

Fix ticket action locking scope in web UI #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4421c3d
Fix ticket action locking scope in web UI
Neokil Jun 9, 2026
592c35a
fix: race condition in optimisticTicketJob causes permanent busy state
Neokil Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { defineConfig, devices } from '@playwright/test';

export default defineConfig({
testDir: './tests',
timeout: 60_000,
expect: { timeout: 30_000 },
timeout: 10_000,
expect: { timeout: 10_000 },
reporter: 'list',
use: {
baseURL: 'http://localhost:8080',
Expand Down
4 changes: 2 additions & 2 deletions e2e/tests/ticket-flow.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function ticketStatus(ticketItem: Locator): Locator {
}

async function waitForStatus(ticketItem: Locator, status: string): Promise<void> {
await expect(ticketStatus(ticketItem)).toContainText(status, { timeout: 30_000 });
await expect(ticketStatus(ticketItem)).toContainText(status, { timeout: 10_000 });
}

test('full ticket lifecycle: add → investigate → implement → done → cleanup', async ({ page }) => {
Expand Down Expand Up @@ -46,7 +46,7 @@ test('full ticket lifecycle: add → investigate → implement → done → clea
await page.getByRole('button', { name: 'Approve' }).click();

// ── 5. Wait for implementation state (Accept button enabled) ────────────
await expect(page.getByRole('button', { name: 'Accept' })).toBeEnabled({ timeout: 30_000 });
await expect(page.getByRole('button', { name: 'Accept' })).toBeEnabled({ timeout: 10_000 });

// ── 6. Accept → transition to done ──────────────────────────────────────
await page.getByRole('button', { name: 'Accept' }).click();
Expand Down
Loading
Loading