Repository navigation
Say Docker starts at boot on the Docker template - #56
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The template now starts its daemon when the sandbox boots, so the docs and the Docker example no longer run start-docker first; it is only mentioned for a daemon that has stopped. Signed-off-by: Mayur Das <mayur.das@neevcloud.com>
mayur-tolexo
force-pushed
the
docs/docker-starts-at-boot
branch
from
October 17, 2026 04:54
bf03a6e to
731d7d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Docker template now starts its daemon when the sandbox boots, so telling people to run
start-dockerfirst is out of date and adds a step they do not need.What
start-docker: it waits for the sandbox to be ready and runs a container.start-dockeris mentioned only for a daemon that has stopped.Checked on dev: a fresh Docker sandbox ran
docker run --rm --network=host hello-worldright after it was Ready, with nostart-docker, and pulled the image from Docker Hub.