Skip to content

Say Docker starts at boot on the Docker template - #56

Merged
mayur-tolexo merged 1 commit into
mainfrom
docs/docker-starts-at-boot
Oct 17, 2026
Merged

mayur-tolexo merged 1 commit into
mainfrom
docs/docker-starts-at-boot

Conversation

@mayur-tolexo

@mayur-tolexo mayur-tolexo commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Why

The Docker template now starts its daemon when the sandbox boots, so telling people to run start-docker first is out of date and adds a step they do not need.

What

  • The template tables in the README, API reference and getting-started guide say Docker starts at boot.
  • The Docker example no longer calls start-docker: it waits for the sandbox to be ready and runs a container. start-docker is mentioned only for a daemon that has stopped.

Checked on dev: a fresh Docker sandbox ran docker run --rm --network=host hello-world right after it was Ready, with no start-docker, and pulled the image from Docker Hub.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d2f13d3f-2d06-4e35-842b-6d7c22c42f21
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The template now starts its daemon when the sandbox boots, so the docs and the Docker example no longer run start-docker first; it is only mentioned for a daemon that has stopped.

Signed-off-by: Mayur Das <mayur.das@neevcloud.com>
@mayur-tolexo
mayur-tolexo force-pushed the docs/docker-starts-at-boot branch from bf03a6e to 731d7d7 Compare October 17, 2026 04:54
@mayur-tolexo
mayur-tolexo merged commit 2b70df0 into main Oct 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant