feat(ui): default the theme to the system preference - #7
Merged
Conversation
The theme fell back to light when neither a stored choice nor --dark was present, so readers on a dark desktop got a light diff on every fresh session. It now falls back to prefers-color-scheme, and follows changes to it for as long as the reader has not picked a theme themselves. Precedence is unchanged where it was already meaningful: a stored choice wins over --dark, which wins over the system. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useThemefell back to'light'when there was neither a stored choice nor--dark, so anyone ona dark desktop got a light diff every time they opened a fresh session.
It now falls back to
prefers-color-scheme, and keeps following changes to it for as long as thereader has not picked a theme themselves — flipping the OS to dark in the evening flips an open diff
with it. Precedence where it was already meaningful is unchanged: a stored choice beats
--dark,which beats the system.
resolveInitialThemeis split out as a pure function so the precedence is unit-tested; the UIpackage's vitest setup has no DOM environment, so testing the hook itself would have meant adding
one. 167 tests pass.
Stacked on #6.
🤖 Generated with Claude Code
https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs