feat(review): show the pull request's own context, and allow a bare verdict - #24
Merged
Conversation
…erdict Reading a diff without the description means re-deriving intent from the code, and without the existing reviews it means repeating a point someone else already made. A collapsible panel above the diff now carries the description as markdown and every existing review with its author, verdict and body. A COMMENTED review with an empty body is dropped: that is what the forge records for a batch of inline comments, and those arrive through the inline pull. A bodiless APPROVED or CHANGES_REQUESTED is kept, because there the verdict is the content. Submitting an approval no longer requires attaching anything. Only a plain comment needs a body or a comment to carry - a verdict stands on its own, in the dialog, in the route validation and in createReview. Fixes a real consequence of the merged-PR checkout fallback: `gh pr view` resolves the pull request from the current branch, so a detached checkout returned no details at all and every forge feature went dark. Details now take the pull request number. Drops an esbuild jsx block from the UI vite config that vite 8 ignores in favour of oxc, and warned about on every test run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a diff without the description means re-deriving the intent from the code; without the existing reviews it means repeating a point someone else already made. A collapsible panel above the diff now carries the description as markdown and every existing review with its author, verdict and body.
Verified on the hardest case — a merged PR with a detached checkout:
That surfaced something invisible before: a second reviewer, and two dismissed verdicts.
One judgement call: a
COMMENTEDreview with an empty body is dropped, because that is what the forge records for a batch of inline comments — those arrive through the inline pull, so the row would be noise. A bodilessAPPROVEDorCHANGES_REQUESTEDis kept, since there the verdict is the content. Both tested.Approving no longer requires attaching anything. Only a plain comment needs a body or a comment to carry; a verdict stands on its own — enforced identically in the dialog (
canSubmitReview), the route validation andcreateReview. The submit button relabels toSubmit approveso it does not promise comments it is not sending.And a real bug from the merged-PR fallback in #23:
gh pr viewresolves the PR from the current branch, so a detached checkout returnednulldetails and every forge feature went dark — no panel, no submitting.fetchDetailsnow takes the PR number, threaded through from PR mode.Also drops an
esbuild.jsxblock from the UI vite config that vite 8 ignores in favour of oxc, and warned about on every test run.TDD: 3 red on
canSubmitReview, 4 red on the panel, 4 red onparseReviews. 297 tests pass.Stacked on #23.
🤖 Generated with Claude Code
https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs