Conversation
…and the PR Two things stopped "review my current draft PR" from working from where people actually stand. A project directory often holds several worktrees as subdirectories rather than being a repository itself, so the command was run outside any repository and failed with "Not a git repository". --repo <path> selects one; everything downstream already resolves against the working directory, so the option only has to move it. The skills now look one level down for repositories and ask which one when there is more than one, rather than guessing. A bare review also defaulted to working-tree changes, which on a branch whose work is committed is an empty diff - exactly the case when reviewing your own draft before marking it Ready. With no ref the skill now asks GitHub whether the branch has a pull request and reviews that, which pins the diff to the pull request's base commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things stopped
review my current draft PRworking from where people actually stand.The repository is often a subdirectory. A project directory holding several worktrees is not itself a repository, so the command failed with
Error: Not a git repository— verified from~/nc/SendgridIdempotency.--repo <path>selects one; everything downstream already resolves against the working directory, so apreActionhook that moves it covers the root command and every subcommand. Passing a non-directory is rejected rather than producing a confusing git error.The skills now look one level down for repositories, use it when there is exactly one, and ask when there are several — listing them with their branches. Guessing reviews the wrong branch, and some project directories here hold thirteen worktrees.
A bare review reviewed the wrong thing. With no ref the skill defaulted to working-tree changes, which on a branch whose work is committed is an empty diff — precisely the case when reviewing your own draft before marking it Ready. Step 0 now asks
gh pr viewwhether the branch has a pull request and reviews that instead, which pins the diff to the base commit via #6. A draft counts. The skill states which it chose, so a wrong guess is cheap to correct.Same discovery step added to
diffity-resolve, the other half of that loop.Stacked on #19.
🤖 Generated with Claude Code
https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs