Skip to content

Add an observable NativePHP scanner benchmark - #7

Closed
prateekbhujel wants to merge 3 commits into
NativePHP:mainfrom
prateekbhujel:benchmark/scanner-path
Closed

prateekbhujel wants to merge 3 commits into
NativePHP:mainfrom
prateekbhujel:benchmark/scanner-path

Conversation

@prateekbhujel

Copy link
Copy Markdown
Contributor

What this adds

  • Adds a native scanner benchmark screen to the Super Stack starter.
  • Measures the coarse scan-to-PHP path separately from PHP-side deduplication.
  • Includes a deterministic QR fixture, feature coverage, and reproduction notes.
  • Registers the open-source CameraX/ML Kit scanner implementation explicitly in the NativePHP plugin provider.

Verification

  • php artisan test --no-ansi — 5 tests, 19 assertions
  • vendor/bin/pint ... --test — clean
  • git diff --check — clean
  • Android debug APK builds and installs on a Xiaomi Android 15 device.

The physical QR scan is the final device-side validation step; the benchmark does not claim React Native parity without a same-device comparison.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7038d144-403d-4f7f-bda4-8271d97b5c3c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@prateekbhujel

Copy link
Copy Markdown
Contributor Author

Closing this because it is not aligned with the intended task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant