Skip to content

Fix Pint code style, add CI Pint check, and remove unused welcome view - #4

Merged
shanerbaner82 merged 2 commits into
NativePHP:mainfrom
prateekbhujel:chore/clean-welcome-view-and-pint-ci
Sep 20, 2026
Merged

shanerbaner82 merged 2 commits into
NativePHP:mainfrom
prateekbhujel:chore/clean-welcome-view-and-pint-ci

Conversation

@prateekbhujel

Copy link
Copy Markdown
Contributor

CONTRIBUTING.md specifies:

"Match existing code style (pint if you touch PHP)"

This PR cleans up code style across the starter kit, enforces style compliance in CI, and removes unused scaffold boilerplate.

Changes

  • Fixed Pint style violations in NativeServiceProvider.php, Home.php, and AppInfoTool.php (ordered imports, strict types, blank lines, trailing newline).
  • Added vendor/bin/pint --test step to .github/workflows/tests.yml.
  • Removed unused 72KB resources/views/welcome.blade.php leftover from laravel new (root / routes directly to Home::class rendering native.home).

Fix code style violations identified by Pint across providers and native
components, enforce Pint checks in the GitHub Actions workflow, and delete
the unused 72KB welcome.blade.php leftover from framework scaffolding.
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c53c2c5f-1bdd-42fa-92a3-bd9c844cbcb6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@shanerbaner82
shanerbaner82 merged commit cea3ad8 into NativePHP:main Sep 20, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants