[Build] Validate Swift 6 library compilation - #87
Conversation
8f959a8 to
bf2d144
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0636d5425
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| path: "AsyncImageView", | ||
| swiftSettings: [ | ||
| // Work around https://github.com/swiftlang/swift/issues/75453. | ||
| .unsafeFlags(["-disable-dynamic-actor-isolation"]) |
There was a problem hiding this comment.
Keep unsafe flags out of the published library target
When AsyncImageView is consumed through a versioned SwiftPM dependency rather than built as the root package, SwiftPM rejects the product with the target 'AsyncImageView' in product 'AsyncImageView' contains unsafe build flags. The new CI job builds the repository directly, so it does not exercise this downstream-package restriction. Pass this compiler workaround from the CI build invocation instead of attaching it to the library target.
Useful? React with 👍 / 👎.
Summary
masterafter the Swift Testing migration landed-disable-dynamic-actor-isolationdispatch_assert_queuecrashes swiftlang/swift#75453Sendable@preconcurrencyfor the Swift 5 ReactiveSwift boundary, avoidingnonisolated(unsafe)storage and unchecked boxesCI reproduction
Commit
82dfc96contains the Swift 6 configuration and CI gate before the production fix. Build and Test run 30112895900 fails in both jobs with the same downstream diagnostic:Commit
b7769e4fixes that failure and the subsequent renderer, scheduler, and deinitializer concurrency errors in this same PR. Commite0636d5incorporates review feedback by replacing the explicit ReactiveSwift escape hatches with@preconcurrencyimports.Validation
swiftlint --config .swiftlint.yml --strictgit diff --checkDependencies
None. The previous test-only commit was superseded by merged PR #88, so this PR is now based directly on
master.