fix CSCL LDF - #2592
Open
damonmcc wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
damonmcc
marked this pull request as ready for review
August 31, 2026 20:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #2522
all builds on this branch
recipe.yml. All four were unset, soint__ldf_headerraised at compile time. Output now matches prod's published 26b header exactly:26A / 02092026 / 26B / 04222026.production_outputsschema, so nothing kept them there.loadhas aborted on a deliberateassert Falsesince July: the citywide union readsbronx_lion, but the tables are namedbronx_lion_dat. Nine QA models source the table it builds.qa__ldf_summaryalready compares positions 1-90. Both validation paths read the exclusion fromrecipe.yml, so they can't disagree about what gets compared.s3://bucket/keyinstead ofClientError: 404 HeadObject.object_existsno longer reports a 403 as "not found". Eight tests added.notes
production_outputsis a single shared schema indb-cscl, and the build now rewrites three of its tables withDROP TABLE ... CASCADE. Two concurrent CSCL builds will race. Giving each build its own copy means splitting the source group, which is more than this change warrants.