exec(at_coroutine_exit): inherit start scheduler only when available#2106
Open
nebkat wants to merge 1 commit into
Open
exec(at_coroutine_exit): inherit start scheduler only when available#2106nebkat wants to merge 1 commit into
nebkat wants to merge 1 commit into
Conversation
The cleanup task's await_suspend unconditionally read get_start_scheduler
from the parent promise's env, which made at_coroutine_exit impossible
to use with tasks whose context doesn't model affinity (e.g.
basic_task<T, inline_task_context<T>>): the call failed to compile.
Gate the read on a requires-expression. When the parent's env doesn't
expose get_start_scheduler, the cleanup task's __scheduler_ keeps its
default value (inline_scheduler{}), which is what callers of an inline
task would expect anyway. Affinity-bearing tasks (default_task_context)
continue to inherit the parent's scheduler as before.
nebkat
force-pushed
the
at-coroutine-exit-optional-scheduler
branch
from
b69360f to
da40fc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup task's
await_suspendunconditionally readsget_start_schedulerfrom the parent promise's env, which madeat_coroutine_exitimpossible to use with tasks whose context doesn't model affinity (e.g.basic_task<T, inline_task_context<T>>): the call failed to compile.Gate the read on a requires-expression. When the parent's env doesn't expose
get_start_scheduler, the cleanup task's__scheduler_keeps its default value (inline_scheduler{}), which is what callers of an inline task would expect anyway. Affinity-bearing tasks (default_task_context) continue to inherit the parent's scheduler as before.I understand this may not be desirable due to risk of stop requester running a complex operation but opening to start a discussion. We run a single main event loop on an embedded device so have no need for the scheduler affinity mechanism.