UQ benchmarking - #49
Open
ktangsali wants to merge 14 commits into
Open
Conversation
…checpoint explicit
Collaborator
Author
|
/blossom-ci |
Collaborator
|
Hi @ktangsali - I see some files use |
physicsnemo renamed FieldGPHead to FieldVariationalGPHead and removed the DUE-style spectral-normalised DKL extractor. The import alias kept this wrapper importable but not constructible: it passed spectral_norm_coeff and dkl_residual unconditionally, so every GP benchmark row died with a TypeError. Rather than silently dropping those two kwargs, reject them with a clear error. Leftover model kwargs are forwarded to the datapipe splitter, which would swallow them, so a config still asking for a spectral-normalised extractor would otherwise build a plain MLP whose parameter layout does not match its checkpoint -- failing later and less obviously. The head-checkpoint fallback now tries FieldVariationalGPHead.0.<epoch>.pt and then the older FieldGPHead.0.<epoch>.pt, since save_checkpoint derives the file stem from the class name and existing runs wrote the old one. Verified the three GP checkpoints scored by the multiclass surface benchmark still load strict=True. config_uq_surface.yaml's GP row loses its DUE settings and now mirrors the settled training recipe (plain DKL MLP + heteroscedastic noise head). Its comments also spell out that stats_path must be the DrivAerStar normalization: those fields are in raw physical units, and the nondimensional stats that used to sit at the shared path belong to the DrivAer AWS runs, so confusing the two mis-scales pressure by ~1600x without failing.
The pre-rename FieldGPHead spelling is gone from physicsnemo, and every GP entry in the benchmark configs names its head checkpoint explicitly, so the exact file is read and the sibling search never runs for them. Accepting both stems only made the fallback and its error harder to follow; the not-found message now names the single path it looked for.
…all and other misc things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo-CFD Pull Request
Description
Updates the model wrappers and the benchmarking workflow to support benchmarking on models with UQ. The PR:
Checklist
Dependencies