test(self-managed): align LLM router pin assertions - #1395
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe self-managed published-chart and split-cluster tests now expect LLM request-router chart version ChangesLLM router chart test assertions
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only aligns self-managed test assertions with the existing 1.12.2 pin; no production behavior changes are introduced, and no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Update release-path expectations after the stack pin moved the LLM request router to 1.12.2.\n\nFixes #1393 Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
436c98a to
22dfe94
Compare
TL;DR
Update normal and published LLM request-router release-path assertions to the 1.12.2 version pinned by #1381.
Additional Details
The Helmfile pin changed in #1381, but two test expectations retained 1.12.1. The broader self-managed test suite therefore failed despite rendering the correct current chart. This PR changes only those expectations.
For the Reviewer
The changed expected values match deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl. There is no production configuration change.
For QA
Ran:
Issues
Fixes #1393
Checklist
Summary by CodeRabbit