Skip to content

test(self-managed): align LLM router pin assertions - #1395

Open
sbaum1994 wants to merge 2 commits into
mainfrom
test/llm-router-pin-assertions
Open

test(self-managed): align LLM router pin assertions#1395
sbaum1994 wants to merge 2 commits into
mainfrom
test/llm-router-pin-assertions

Conversation

@sbaum1994

@sbaum1994 sbaum1994 commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

TL;DR

Update normal and published LLM request-router release-path assertions to the 1.12.2 version pinned by #1381.

Additional Details

The Helmfile pin changed in #1381, but two test expectations retained 1.12.1. The broader self-managed test suite therefore failed despite rendering the correct current chart. This PR changes only those expectations.

For the Reviewer

The changed expected values match deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl. There is no production configuration change.

For QA

Ran:

  • bash deploy/stacks/self-managed/tests/llm-router-split-cluster.sh
  • make -C deploy/stacks/self-managed test

Issues

Fixes #1393

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Summary by CodeRabbit

  • Updates
    • Updated the self-managed LLM request-router deployment checks to validate chart version 1.12.2.
    • Ensures both published-chart and split-cluster deployment scenarios recognize the latest chart release.

@sbaum1994
sbaum1994 requested a review from a team as a code owner August 31, 2026 08:25
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fee184c9-4378-43ce-83a5-f880a1202a35

📥 Commits

Reviewing files that changed from the base of the PR and between 9982ad7 and 436c98a.

📒 Files selected for processing (2)
  • deploy/stacks/self-managed/tests/llm-router-published-chart.sh
  • deploy/stacks/self-managed/tests/llm-router-split-cluster.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The self-managed published-chart and split-cluster tests now expect LLM request-router chart version 1.12.2 instead of 1.12.1.

Changes

LLM router chart test assertions

Layer / File(s) Summary
Update chart version assertions
deploy/stacks/self-managed/tests/llm-router-published-chart.sh, deploy/stacks/self-managed/tests/llm-router-split-cluster.sh
The tests now expect chart version 1.12.2. The split-cluster failure message uses the updated version.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 436c9

This change only aligns self-managed test assertions with the existing 1.12.2 pin; no production behavior changes are introduced, and no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: kferris-nvidia

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses the valid Conventional Commits format test(self-managed): ... and accurately describes the test assertion updates.
Linked Issues check ✅ Passed The pull request updates both stale self-managed LLM router version assertions from 1.12.1 to 1.12.2, which satisfies issue #1393.
Out of Scope Changes check ✅ Passed The changes are limited to the two required self-managed test expectation updates. No unrelated production configuration changes are included.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/llm-router-pin-assertions

Comment @coderabbitai help to get the list of available commands.

Update release-path expectations after the stack pin moved the LLM request router to 1.12.2.\n\nFixes #1393

Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
@sbaum1994
sbaum1994 force-pushed the test/llm-router-pin-assertions branch from 436c98a to 22dfe94 Compare August 31, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(self-managed): align LLM router pin assertions with 1.12.2

1 participant