feat(health)!: add multi-target support for OTLP sinks#3415
Draft
jayzhudev wants to merge 1 commit into
Draft
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Jay Zhu <jayzhu@nvidia.com>
a74ffa6 to
02c3a74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add multi-target support to the OTLP sink.
The OTLP sink now accepts a required
targetslist. Each target has its own name, endpoint, batching settings, and diagnostic inclusion setting. Logs and metrics emitted to the OTLP sink are forwarded to every configured target, with independent queues and drains so a slow or unavailable target does not block other targets.Related issues
Closes #3414
Type of Change
Breaking Changes
This PR changes the configuration surface for the OTLP sink in
carbide-health. Depending on existing deployment configurations, this PR may or may not require a config update.The previous top-level OTLP fields are replaced by
sinks.otlp.targets.Before:
After:
Testing
Additional Notes
Helm and deployment templates do not appear to require updates because they do not currently template
sinks.otlpsettings.