Skip to content

feat(health)!: add multi-target support for OTLP sinks#3415

Draft
jayzhudev wants to merge 1 commit into
NVIDIA:mainfrom
jayzhudev:health/multiple-otlp-targets
Draft

feat(health)!: add multi-target support for OTLP sinks#3415
jayzhudev wants to merge 1 commit into
NVIDIA:mainfrom
jayzhudev:health/multiple-otlp-targets

Conversation

@jayzhudev

@jayzhudev jayzhudev commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Add multi-target support to the OTLP sink.

The OTLP sink now accepts a required targets list. Each target has its own name, endpoint, batching settings, and diagnostic inclusion setting. Logs and metrics emitted to the OTLP sink are forwarded to every configured target, with independent queues and drains so a slow or unavailable target does not block other targets.

Related issues

Closes #3414

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

This PR changes the configuration surface for the OTLP sink in carbide-health. Depending on existing deployment configurations, this PR may or may not require a config update.

The previous top-level OTLP fields are replaced by sinks.otlp.targets.

Before:

[sinks.otlp]
enabled = true
endpoint = "http://localhost:4317"
batch_size = 512
flush_interval = "2s"
include_diagnostics = false

After:

[sinks.otlp]
enabled = true

[[sinks.otlp.targets]]
name = "default"
endpoint = "http://localhost:4317"
batch_size = 512
flush_interval = "2s"
include_diagnostics = false

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Helm and deployment templates do not appear to require updates because they do not currently template sinks.otlp settings.

@jayzhudev jayzhudev self-assigned this Jul 13, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b4e9f284-5705-4dbf-b974-e112d0de79e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Jay Zhu <jayzhu@nvidia.com>
@jayzhudev jayzhudev force-pushed the health/multiple-otlp-targets branch from a74ffa6 to 02c3a74 Compare July 13, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support multiple targets in hw-health OTLP sink

1 participant