docs(network): document MNNVL rack IP requirements in prerequisites#3399
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe network prerequisites documentation adds IP accounting for MNNVL racks, covering switch BMC, NVOS instances, and power shelf PMC allocations. ChangesNetwork Documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/getting-started/prerequisites/network.md`:
- Line 24: Clarify the table row’s allocation scope by indicating that the three
switch BMC/NVOS addresses are per node, while the single power shelf PMC address
is per rack; state the total as 3N + 1 IPs for a rack with N nodes rather than
implying 4 IPs per node.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b3d9814b-452b-4e4f-a3dc-6f161a39f71f
📒 Files selected for processing (1)
docs/getting-started/prerequisites/network.md
aswaroop-nv
left a comment
There was a problem hiding this comment.
Will update doc
675443e to
b0b9aef
Compare
b0b9aef to
2c972af
Compare
🔍 Container Scan SummaryNo Grype artifacts were found to aggregate. |
Add MNNVL rack IP counts (3 per switch: BMC + 2 NVOS, plus 1 per power shelf PMC) to the managed-hosts management network table so site planners can size OOB pools correctly. Signed-off-by: Anil Swaroop <aswaroop@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pull-request-3399.docs.buildwithfern.com/infra-controller |
2c972af to
923b9dc
Compare
Add control-plane management IP counts for MNNVL racks (switch BMC, two NVOS addresses, and power shelf PMC) so site planners can size OOB pools correctly alongside standard host/DPU nodes.
Related issues
Type of Change
Breaking Changes
Testing
Additional Notes
Adds a row to the Control Plane Management Network table for MNNVL racks:
3 IPs per node (switch BMC + 2 NVOS) + 1 (power shelf PMC).