Skip to content

docs(network): document MNNVL rack IP requirements in prerequisites#3399

Merged
aswaroop-nv merged 1 commit into
NVIDIA:mainfrom
aswaroop-nv:chore/networking-update
Jul 13, 2026
Merged

docs(network): document MNNVL rack IP requirements in prerequisites#3399
aswaroop-nv merged 1 commit into
NVIDIA:mainfrom
aswaroop-nv:chore/networking-update

Conversation

@aswaroop-nv

Copy link
Copy Markdown
Contributor

Add control-plane management IP counts for MNNVL racks (switch BMC, two NVOS addresses, and power shelf PMC) so site planners can size OOB pools correctly alongside standard host/DPU nodes.

Related issues

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Adds a row to the Control Plane Management Network table for MNNVL racks:
3 IPs per node (switch BMC + 2 NVOS) + 1 (power shelf PMC).

@aswaroop-nv aswaroop-nv requested a review from zhaozhongn July 11, 2026 02:12
@aswaroop-nv aswaroop-nv requested a review from polarweasel as a code owner July 11, 2026 02:12
@copy-pr-bot

copy-pr-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The network prerequisites documentation adds IP accounting for MNNVL racks, covering switch BMC, NVOS instances, and power shelf PMC allocations.

Changes

Network Documentation

Layer / File(s) Summary
MNNVL IP accounting
docs/getting-started/prerequisites/network.md
Adds the requirement of 3 per switch (BMC + 2 NVOS) + 1 per power shelf PMC IPs for MNNVL racks.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the doc update and the MNNVL rack IP requirement change.
Description check ✅ Passed The description accurately explains the added MNNVL management IP counts and matches the documented change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/getting-started/prerequisites/network.md`:
- Line 24: Clarify the table row’s allocation scope by indicating that the three
switch BMC/NVOS addresses are per node, while the single power shelf PMC address
is per rack; state the total as 3N + 1 IPs for a rack with N nodes rather than
implying 4 IPs per node.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b3d9814b-452b-4e4f-a3dc-6f161a39f71f

📥 Commits

Reviewing files that changed from the base of the PR and between 83ea2c4 and 172e004.

📒 Files selected for processing (1)
  • docs/getting-started/prerequisites/network.md

Comment thread docs/getting-started/prerequisites/network.md Outdated

@aswaroop-nv aswaroop-nv left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update doc

@aswaroop-nv aswaroop-nv force-pushed the chore/networking-update branch 2 times, most recently from 675443e to b0b9aef Compare July 11, 2026 18:01
@aswaroop-nv aswaroop-nv force-pushed the chore/networking-update branch from b0b9aef to 2c972af Compare July 13, 2026 23:35
@github-actions

Copy link
Copy Markdown

🔍 Container Scan Summary

No Grype artifacts were found to aggregate.

Add MNNVL rack IP counts (3 per switch: BMC + 2 NVOS, plus 1 per power
shelf PMC) to the managed-hosts management network table so site planners
can size OOB pools correctly.

Signed-off-by: Anil Swaroop <aswaroop@nvidia.com>
@github-actions

Copy link
Copy Markdown

@aswaroop-nv aswaroop-nv force-pushed the chore/networking-update branch from 2c972af to 923b9dc Compare July 13, 2026 23:36
@aswaroop-nv aswaroop-nv merged commit 69cd51c into NVIDIA:main Jul 13, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants