Skip to content

[Crazy RoboTaxi] Improve Crazy Robotaxi controller handling - #613

Open
aidanfnv wants to merge 1 commit into
mainfrom
dev/aidanf/game/crazy-robotaxi/controller-input
Open

aidanfnv wants to merge 1 commit into
mainfrom
dev/aidanf/game/crazy-robotaxi/controller-input

Conversation

@aidanfnv

Copy link
Copy Markdown
Collaborator

Split off from #553, this change modifies the controller handling to make the game feel better on a controller, such as by restoring analog steering. Previously, to make steering more responsive, it was apparently changed to be digital.

@aidanfnv
aidanfnv added this pull request to stack #610 September 11, 2026 00:21
@copy-pr-bot

copy-pr-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The current PR appears safe to merge; no actionable new failures were introduced since the previous review.

Summary

This PR improves Crazy RoboTaxi controller handling while preserving keyboard support.

  • Restores proportional gamepad steering and pedal input with rescaled dead zones.
  • Unifies keyboard and gamepad commands around the shared arcade-driving command shape.
  • Rate-limits direct steering to retain responsive but smooth vehicle behavior.
  • Allows the most recent deliberate keyboard or controller input to select the active source.
  • Adds focused control, gameplay, and engine-input tests for the updated behavior.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  K[Keyboard event] --> KC[Keyboard DriverCommand]
  G[Gamepad state] --> DZ[Rescaled dead zones]
  DZ --> GC[Gamepad DriverCommand]
  W[Wheel state] --> WC[Wheel DriverCommand]
  KC --> A[Most recent deliberate input arbitration]
  GC --> A
  WC --> A
  A --> C[Active DriverCommand]
  C --> D[Taxi dynamics]
  D --> S[Rate-limited steering target]
Loading

Reviews (10) · Last reviewed commit: "Improve Crazy Robotaxi controller handli..."

@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/controller-input branch from 7627d57 to 54114a8 Compare September 11, 2026 02:30
@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/controller-input branch 2 times, most recently from 1827096 to edcfb83 Compare September 12, 2026 00:14
@aidanfnv

Copy link
Copy Markdown
Collaborator Author

/ok to test edcfb83

@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/controller-input branch 2 times, most recently from c9a52c5 to 6a75f82 Compare September 12, 2026 01:29
@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/controller-input branch from 6a75f82 to fabbef9 Compare September 14, 2026 16:40
@aidanfnv

Copy link
Copy Markdown
Collaborator Author

/ok to test fabbef9

@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/controller-input branch from fabbef9 to b629dd1 Compare September 14, 2026 22:52
@aidanfnv
aidanfnv force-pushed the dev/aidanf/game/crazy-robotaxi/controller-input branch from b629dd1 to 06c6834 Compare September 16, 2026 16:56
Base automatically changed from dev/aidanf/game/crazy-robotaxi/controls to main September 16, 2026 20:55
Signed-off-by: Aidan Foster <aidanf@nvidia.com>
@jmccaffrey-nv
jmccaffrey-nv force-pushed the dev/aidanf/game/crazy-robotaxi/controller-input branch from 06c6834 to 7acfe94 Compare September 16, 2026 20:55

@spaingnv spaingnv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. New tests cover command shape, dead zones, and keyboard vs pad ownership.

@spaingnv

Copy link
Copy Markdown
Collaborator

/ok to test 7acfe94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants