tests: retire correctness/regression tests covered by C++ gtests#1461
Conversation
Remove 5 Python tests whose only role was asserting specific solver output values. Correctness for these code paths is already covered by C++ gtests; the Python suite should focus on API behavior. - Delete test_qp.py::test_solver — QP objective/variable values covered by cpp/tests/linear_programming/qp_test.cu; QP API covered by test_python_API.py quadratic_objective/matrix tests - Remove test_solver.py::test_solomon — VRPTW objective/vehicle count; routing API covered by test_vehicle_properties.py - Remove test_solver.py::test_pdptw — PDP objective value; pickup- delivery pairs API covered by test_vehicle_properties.py::test_heterogenous_breaks - Remove test_distance_engine.py::test_compute_cost_matrix — numerical matrix match against reference CSV; compute_cost_matrix API covered by test_compute_waypoint_sequence_* tests - Remove test_distance_engine.py::test_compute_shortest_path_costs — exact matrix match; error-path coverage kept in test_target_locations_validity Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe PR removes one quadratic-programming test module and prunes several routing, callback, and SOCP test cases. It also simplifies imports in the affected routing test files. ChangesRouting test pruning
Incumbent callback inputs
SOCP regression pruning
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🔔 Hi @anandhkb @ramakrishnap-nv, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
1 similar comment
|
🔔 Hi @anandhkb @ramakrishnap-nv, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
…icts Conflict resolutions: - test_incumbent_callbacks.py: keep PR's removal of swath1.mps from both parametrize lists - test_distance_engine.py: use main's copyright comma format; keep PR's removal of test_compute_cost_matrix and its helper functions - test_socp.py: drop unused EXPECTED_SOCP_3_* constants (inlined by main); keep PR's removal of test_socp_1_barrier_solution and test_general_quadratic_unsymmetric; include new test_rotated_soc_natural_cross_term_barrier_solution added on main Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
/ok to test 04fbd46 |
CI Test Summary✅ All 22 test job(s) passed. |
|
/merge |
Remove 5 Python tests that assert specific solver output values. The Python test suite should cover API behavior; correctness and regression coverage for these cases already exists in the C++ gtest suite.
Removed tests:
test_qp.py::test_solver— asserted QP objective −32 and variable valuesx1=4, x2=2. QP correctness covered bycpp/tests/linear_programming/qp_test.cu; QP API covered bytest_python_API.py::test_quadratic_objective_*tests.test_solver.py::test_solomon— asserted VRPTW objective ~1087.15 and vehicle count ≤12. Routing API covered bytest_vehicle_properties.py.test_solver.py::test_pdptw— asserted PDP objective 13.0. Pickup-delivery pairs API covered bytest_vehicle_properties.py::test_heterogenous_breaks.test_distance_engine.py::test_compute_cost_matrix— numerical matrix match against reference CSVs.compute_cost_matrixAPI covered by the kepttest_compute_waypoint_sequence_*tests.test_distance_engine.py::test_compute_shortest_path_costs— exact matrix match against hardcoded expected values. Error-path coverage forcompute_shortest_path_costsretained intest_target_locations_validity.Also removes helper functions and imports that were only used by the deleted tests.