Use cuda::stream_ref for central stream helpers - #23770
Draft
vyasr wants to merge 2 commits into
Draft
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
3 tasks
vyasr
added
libcudf
github-actions
Bot
removed
improvement
vyasr
added
improvement
mythrocks
reviewed
Aug 24, 2026
| stream_refs.reserve(streams.size()); | ||
| for (auto const s : streams) { | ||
| stream_refs.emplace_back(s); | ||
| } |
Contributor
There was a problem hiding this comment.
Silly question: Why is this not std::copy() to back_inserter{stream_refs}?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Wave 2 follow-up to #23691 migrates the central stream helpers from
rmm::cuda_stream_viewtocuda::stream_ref, includingget_default_stream(),default_stream_value,fork_streams, andjoin_streams.It also updates the direct Java, pylibcudf, and libcudf_streaming call sites whose method calls depend on those helper return types.
rmm::cuda_streamownership remains unchanged.This should land after the Wave 1 downstream
stream_refPRs.Replaces the fork PR vyasr#9.
Contributes to #23636
Checklist