Surface code demo 1 refactor#685
Draft
eliotheinrich wants to merge 11 commits into
Draft
Conversation
… window decoder Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
…nd syndrome enqueuing Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
…AQ_QEC_MEMORY_CIRCUIT_DECLARATIONS_ONLY Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
…' into pr-surface-code-demo
…urface-code-demo # Conflicts: # libs/qec/lib/experiments.cpp # libs/qec/unittests/backend-specific/stim/test_qec_stim.cpp
Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
…der context Signed-off-by: Eliot Heinrich <eheinrich@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the surface code demo (/libs/qec/unittests/realtime/app_examples/surface_code-1.cpp) to use the new syndrome format, memory circuit kernel, and decoder context. Semantically, the demo should remain very similar to the original version, but I have aimed to remove the hand-rolled sections and replace them with CUDA-QX features as much as possible.
NOTE: This is still a relatively early draft, and includes changes from several dependencies at the moment; it will likely change as the dependencies are modified during review, and the diff will shrink as other PRs merge.
Depends on #656, #671, and #676.
Runtime / performance impact
N/A
Self-review checklist
Please confirm each item before requesting review. Check
[x]or strikethrough and explain.
Before requesting review
Scope and size
(if so, an issue has been raised).
Tests
just when it is missing.
EXPECT_*/assertchecks areinsufficient for algorithmic correctness.
Documentation
tracked.
Code style
snake_casevscamelCase) forthe area being modified.
Dependencies
OSRB tickets filed.