Handle CUDA checkpoint restore arg layouts#2144
Open
kkraus14 wants to merge 1 commit into
Open
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
the
cuda.bindings
Collaborator
Author
|
/ok to test |
kkraus14
added
P0
|
rparolin
approved these changes
May 27, 2026
kkraus14
force-pushed
the
codex/fix-checkpoint-restoreargs
branch
from
8d7dd31 to
ae8888c
Compare
kkraus14
force-pushed
the
codex/fix-checkpoint-restoreargs
branch
from
ae8888c to
9ba2616
Compare
Collaborator
Author
|
/ok to test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CUcheckpointRestoreArgs_st.reservedheader rewrite so pyclibrary keeps parsing the struct and typedef.CUcheckpointRestoreArgs_stfor the CUDA 12.x, CUDA 13.2, and CUDA 13.3 restore-argument layouts, including the CUDA 13.2reserved1field.Validation
cuda.hsnapshots for CUDA 12.9, 13.2, and 13.3;CUcheckpointRestoreArgsis present in all three and the generated layouts match the headers.cuda.hsizeof-array expressions and empty named structs; no extra empty named structs remain in 13.3 after the fix.python -m compileall cuda_bindings/build_hooks.pypixi build --output-dir /tmp/cuda-bindings-build-check2 --cleanno longer hits the CUDA 12.9 checkpoint restore compile error; the build continues through thecuda.bindings.driverlink step and then fails on unrelatedcufilesymbols missing from the selected CUDA 12.xlibcufile-dev.pixi buildattempt was also blocked by unrelated newernvrtcsymbols / stale parser-cache behavior (nvrtcBundledHeadersInfo,NVRTC_ERROR_BUSY), not by checkpoint restore generation.