[CUB] Fix GCC 8/9 segmented-sort tuning tests - #11023
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change explicitly constructs ChangesSegmented-sort policy construction
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This is a localized test-only compiler-compatibility fix that preserves behavior; no actionable merge-blocking risk remains beyond normal checks and review. Comment |
|
/ok to test 2bf5d40 |
AI failure analysis1. cugraph uses deleted RMM device_scalar rvalue constructor · 1 jobExplanation: cugraph initializes `device_scalar<size_t>` from a temporary `size_t{0}`, while the RMM version built from `main` deletes exactly that rvalue overload, causing every translation unit instantiating these headers to fail. The PR diff changes only two CUB test return expressions, and the log omits the external repository SHAs, so moving RAPIDS dependency drift is the likely cause rather than the PR. Evidence: Copy this prompt into a coding agentJobs: |
Description
Related: #9037
GCC 8 and GCC 9 reject the untyped braced return in the templated segmented-sort tuning selectors. This causes the CUB environment test translation units to fail before the tests run.
Explicitly construct
cub::SegmentedSortPolicyin both the keys and pairs tuning tests. This preserves behavior while restoring compatibility with the supported compilers.This PR extracts only the two CUB fixes originally authored by @alliepiper in #9037.
Nightly failure: https://github.com/NVIDIA/cccl/actions/runs/32926367884
Testing
cub.test.device.segmented_sort_keys_env.lid_0cub.test.device.segmented_sort_pairs_env.lid_0Checklist