Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
"breathe",
"autoapi.extension",
"sphinx_tabs.tabs",
"myst_parser",
"nvidia-sphinx-theme",
]

templates_path = ["_templates"]
Expand All @@ -77,26 +79,22 @@
# -- Options for HTML output -------------------------------------------------
# https://www.sphinx-doc.org/en/master/usage/configuration.html#options-for-html-output

html_theme = "sphinx_rtd_theme"
html_static_path = ["_static"]
html_show_sphinx = False

html_css_files = [
"css/nvidia_font.css",
"css/nvidia_footer.css",
"css/output-style.css",
"css/diagram-colors.css",
"css/sphinx_tabs.css",
"css/svg-responsive.css",
"css/rtabs.css",
]

html_theme = "nvidia_sphinx_theme"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Configured theme is unavailable

When CI, nightly publishing, or the documented local build runs, Sphinx loads nvidia_sphinx_theme, but those environments install or clone only sphinx_rtd_theme, causing the documentation build to abort before producing HTML.

html_theme_options = {
"collapse_navigation": False,
"logo_only": False,
"version_selector": False,
"language_selector": False,
"public_docs_features": True,
"switcher": {
Comment thread
zredeaux07 marked this conversation as resolved.
"json_url": "../versions1.json",
"version_match": release,
},
"icon_links": [
{
"name": "GitHub",
"url": "https://github.com/NVIDIA/TransformerEngine/",
"icon": "fa-brands fa-github",
}
],
}
html_extra_path = ["project.json", "versions1.json"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Extra-path files are missing

When Sphinx processes html_extra_path, it attempts to copy project.json and versions1.json, but neither file exists and no build step generates them, causing missing-file warnings that fail the -W documentation build and leave the switcher data unavailable.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will need to be created for the project.


napoleon_custom_sections = [
("Parallelism parameters", "params_style"),
Expand Down
1 change: 1 addition & 0 deletions docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Transformer Engine documentation
installation
getting_started/index
faq
release_notes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Toctree target cannot resolve

When Sphinx builds this toctree, it resolves release_notes using the configured .rst source suffix, but the PR creates only the extensionless docs/release_notes file, causing a nonexistent-document warning that the CI workflow's -W option turns into a build failure.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
release_notes
release_notes.md

Only needed if content remains in MD.


.. toctree::
:hidden:
Expand Down
1 change: 1 addition & 0 deletions docs/release_notes.rst

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should either be renamed to "release_notes.md" or the TE team will need to provide the release notes content as RST for future releases. They are currently provided as an MD file.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Paste in the latest release notes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add our copyright header here

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do! Thank you @ksivaman!

Loading