Skip to content

[https://nvbugs/6669206][test] Unwaive test_kimi_k3_gen_dep[1] fixed by #18226 - #18371

Merged
brnguyen2 merged 1 commit into
NVIDIA:mainfrom
brnguyen2:user/brnguyen/unwaive-6669206
Aug 28, 2026
Merged

[https://nvbugs/6669206][test] Unwaive test_kimi_k3_gen_dep[1] fixed by #18226#18371
brnguyen2 merged 1 commit into
NVIDIA:mainfrom
brnguyen2:user/brnguyen/unwaive-6669206

Conversation

@brnguyen2

@brnguyen2 brnguyen2 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Description

The Kimi K3 MLA decode backend-selection defect behind test_kimi_k3_gen_dep[1] (nvbugs/6669206) was fixed in #18226, which keeps CuTe-DSL MLA decode for H=96 speculative-verify batches instead of downgrading them to trtllm-gen (whose MLA decode rejects 64 < num_heads_q < 128). That fix is already merged, but the test's waiver in waives.txt was left behind, so the test remains skipped in CI. This PR removes the now-stale waiver to re-enable it.

Test Coverage

unittest/tools/test_layer_wise_benchmarks.py::test_kimi_k3_gen_dep[1] (single-GPU, DGX_B200-PyTorch). Verified passing locally on B200 with the merged fix (1 passed, ~105s).

PR Checklist

Dev Engineer Review

  • Removed the stale waiver for unittest/tools/test_layer_wise_benchmarks.py::test_kimi_k3_gen_dep[1].
  • The change uses valid waives.txt format.
  • No production code or API changes are included.
  • The waiver removal is consistent with the fix in #18226 and local B200 verification.

QA Engineer Review

  • No test-db/ or qa/ files were modified.
  • Removed one entry from tests/integration/test_lists/waives.txt.
  • CBTS coverage data is unavailable.
  • Verdict: needs follow-up.

NVIDIA#18226

The Kimi K3 MLA decode backend-selection defect behind this failure was
fixed in NVIDIA#18226 (keep CuTe-DSL MLA decode for H=96 speculative-verify
batches). Remove the now-stale waiver so
unittest/tools/test_layer_wise_benchmarks.py::test_kimi_k3_gen_dep[1]
runs again on B200.

Verified locally on B200 with the fix present: the test passes
(1 passed, ~105s).

Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
@brnguyen2

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_B200-PyTorch-*"

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: abf41f25-560a-4d65-b683-c5c123618f5a

📥 Commits

Reviewing files that changed from the base of the PR and between 7110513 and 0a4b177.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The change removes the waiver entry for test_kimi_k3_gen_dep[1] from the integration test list.

Changes

Cohort / File(s) Summary
Test waiver removal
tests/integration/test_lists/waives.txt
Removes the skip entry for unittest/tools/test_layer_wise_benchmarks.py::test_kimi_k3_gen_dep[1].

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 0a4b1

This localized change re-enables an existing test after its underlying fix was merged; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required ticket-and-type format and clearly states that the stale waiver is being removed for the fixed test.
Description check ✅ Passed The description explains the defect, the reason for removing the waiver, the affected test, test coverage, and relevant checklist items. It is sufficiently complete for this test-list-only change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #69983 [ run ] triggered by Bot. Commit: 0a4b177 Link to invocation

@brnguyen2

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Waiver-removal only (one line); the underlying fix landed in #18226. The unwaived test unittest/tools/test_layer_wise_benchmarks.py::test_kimi_k3_gen_dep[1] passed in the targeted DGX_B200-PyTorch CI run (L0_MergeRequest_PR #57263, single-GPU test job 63/63 stages green)."

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #69983 [ run ] completed with state SUCCESS. Commit: 0a4b177
/LLM/main/L0_MergeRequest_PR pipeline #57263 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70032 [ skip ] triggered by Bot. Commit: 0a4b177 Link to invocation

@brnguyen2
brnguyen2 enabled auto-merge (squash) August 28, 2026 17:56
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70032 [ skip ] completed with state SUCCESS. Commit: 0a4b177
Skipping testing for commit 0a4b177

Link to invocation

@brnguyen2
brnguyen2 merged commit 32655ab into NVIDIA:main Aug 28, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants