[https://nvbugs/6458213][test] use TRTLLM MoE for Blackwell skip-softmax tests - #17623
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. WalkthroughThe change adds architecture-dependent ChangesSkip-softmax attention test configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR changes the backend used by Blackwell accuracy tests and removes two test waivers; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast --post-merge |
|
PR_Github #65836 [ run ] triggered by Bot. Commit: |
|
PR_Github #65836 Bot args parsing error: CI requested by |
|
Removed the "ci: post-merge approved" label because @bobboli could not be verified as an active member of NVIDIA/trt-llm-ci-approvers. Ask a member of that team to apply it. |
|
/bot run --disable-fail-fast --post-merge |
|
PR_Github #65842 [ run ] triggered by Bot. Commit: |
|
PR_Github #65842 Bot args parsing error: CI requested by |
|
/bot run --disable-fail-fast --post-merge |
|
PR_Github #65880 [ run ] triggered by Bot. Commit: |
|
PR_Github #65880 [ run ] completed with state
|
|
/bot run --disable-fail-fast --post-merge --reuse-test |
|
PR_Github #65969 [ run ] triggered by Bot. Commit: |
|
PR_Github #65969 [ run ] completed with state
|
|
/bot run --disable-fail-fast --post-merge --reuse-test |
|
PR_Github #66161 [ run ] triggered by Bot. Commit: |
|
PR_Github #66161 [ run ] completed with state
|
359cb30 to
8be625b
Compare
|
/bot run --disable-fail-fast --post-merge --reuse-test |
|
PR_Github #66219 [ run ] triggered by Bot. Commit: |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/bot run --disable-fail-fast --post-merge |
|
PR_Github #69056 [ run ] triggered by Bot. Commit: |
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
fbe551f to
a79c220
Compare
|
/bot run --disable-fail-fast --post-merge |
|
PR_Github #69066 [ run ] triggered by Bot. Commit: |
|
PR_Github #69056 [ run ] completed with state |
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
|
/bot run --disable-fail-fast --post-merge |
|
PR_Github #69070 [ run ] triggered by Bot. Commit: |
|
PR_Github #69066 [ run ] completed with state |
|
/bot run --disable-fail-fast --post-merge |
|
PR_Github #69086 [ run ] triggered by Bot. Commit: |
|
PR_Github #69070 [ run ] completed with state |
|
PR_Github #69086 [ run ] completed with state |
Description
Use the TRTLLM MoE backend for the Qwen3-30B-A3B skip-softmax accuracy tests on SM100 and SM103 Blackwell GPUs. Other architectures continue to use the AUTO backend, so Hopper remains on its supported MoE path.
The B200 4-GPU test intermittently produced NaN sampling inputs. CUDA error 710 and the later CUTLASS TMA descriptor failure are downstream effects of the device-side NaN assertion, so the log does not prove CUTLASS is the root cause. This change treats CUTLASS MoE as the leading hypothesis and switches the Blackwell tests to TRTLLM as a practical mitigation.
The PR removes both remaining Qwen3 skip-softmax waivers: the single-GPU B200 waiver associated with NVBug 6606551 and the H100 4-GPU waiver associated with duplicate NVBug 6523809. The DeepSeekR1 waiver previously included in this PR has already been removed from current main and is no longer part of the rebased diff.
Test Coverage
python3 -m py_compile tests/integration/defs/accuracy/test_llm_api_pytorch.pypre-commit run --files tests/integration/defs/accuracy/test_llm_api_pytorch.py tests/integration/test_lists/waives.txtBoth passed. GPU validation is required in CI on the applicable Blackwell and H100/H200 stages.
PR Checklist
Dev Engineer Review
QA Engineer Review
tests/integration/defs/accuracy/test_llm_api_pytorch.py.tests/integration/test_lists/waives.txt.test-db/orqa/files were modified.