Skip to content

test(testkit): name unsupported gateway auth modes in the error - #5248

Open
elezar wants to merge 1 commit into
mainfrom
claude/sad-bartik-8e1c0b
Open

elezar wants to merge 1 commit into
mainfrom
claude/sad-bartik-8e1c0b

Conversation

@elezar

@elezar elezar commented Nov 4, 2026

Copy link
Copy Markdown
Member

Summary

Add a unit test that Gateway::registered names the gateway and the auth mode when it rejects an unsupported one (for example OIDC). Split out of #5138, where the test was outside that PR's scope.

Related Issue

None. This is a small test-only change from an author with write access.

Changes

  • Add unsupported_auth_modes_are_named to tests/testkit/testkit/src/gateway.rs. It checks the error reads gateway edge uses oidc auth.

Testing

  • Checks appropriate to the affected code and behavior pass: fmt and clippy (--all-targets -D warnings) are clean for the testkit workspace.
  • Unit tests added/updated: cargo test in tests/testkit passes (12 tests in testkit, 1 in testkit-macros), including the new test.
  • E2E tests added/updated (not applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable)

Co-authored-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>

@matthewgrossman matthewgrossman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is the same test as in #5138, and Branch Checks are green.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Related to CI/CD and builds topic:testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants