Repository navigation
Conversation
Replace the untyped Option<String> hook key with a crate-private Key enum whose variants are separate namespaces, and take the key out of Hook::new in favor of a keyed() builder. No behavior change. Signed-off-by: Evan Lezar <elezar@nvidia.com>
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5219 (testkit cleanup hooks), addressing two design nits from its review.
Option<String>hook key with a crate-privateKeyenum. Variants are separate namespaces, so keys of different kinds can't collide.push_keyedtakes aKeyandremovetakes&Key.Hook::newand add akeyed()builder. Anonymous user hooks have no key.Pure refactor with no behavior change: ordering, dedupe, timeouts, and the public API are unchanged, and
Keyis crate-private. Onlycleanup.rsandcontext.rschange.Verified from
tests/testkit:cargo fmt --all,cargo nextest run(12 pass),cargo clippy --all-targets -- -D warnings.No linked issue: the author has write access on this repository, as AGENTS.md permits.