Repository navigation
fix(server): budget SSH relays and service forwards separately - #5063
Open
ericcurtin wants to merge 1 commit into
Open
ericcurtin wants to merge 1 commit into
ericcurtin wants to merge 1 commit into
Conversation
Open service forwards no longer block SSH. Both per-sandbox caps are configurable and the limit error names the exhausted budget. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
@krishicks @matthewgrossman could you please triage #4472 so the issue check can pass? @drew @mrunalp PTAL, and |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSH relays and service forwards now have separate per-sandbox budgets, so open forwards no longer block SSH.
Related Issue
Closes #4472
Changes
max_ssh_connections_per_sandboxandmax_service_connections_per_sandboxgateway settings (default 20, minimum 1).Release Notes
SSH and service forward connections have separate per-sandbox limits, both configurable in the gateway config.
Testing
cargo fmt,cargo clippy -D warnings, and lib tests for core and server pass.Checklist