Repository navigation
feat(auth): authenticate gateway-mediated application requests - #4959
Merged
TaylorMutch merged 0 commit intoOct 27, 2026
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4959.docs.buildwithfern.com/openshell |
This was referenced Oct 26, 2026
TaylorMutch
force-pushed
the
feat/4722-gateway-service-auth/TaylorMutch
branch
from
October 27, 2026 03:15
3cfff3e to
3f962b0
Compare
TaylorMutch
force-pushed
the
feat/4722-gateway-service-auth/TaylorMutch
branch
from
October 27, 2026 05:42
3f962b0 to
18b394a
Compare
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by draft #4963. GitHub automatically marked this PR merged into its former SDK base during publication of the reordered stack. Main was unchanged. Review #4963 for the isolated gateway application authentication change.
Summary
Authenticate and authorize gateway-mediated application HTTP requests and WebSocket upgrades before connecting upstream. Support browser login/session access and separate gateway credentials from application-owned bearer tokens and cookies.
Stacked on the Go SDK discovery PR. This commit excludes the example Kubernetes controller.
Related Issue
Closes #4722.
The linked issue currently has no
state:acceptedlabel; the author has verified repository ADMIN access.Changes
X-OpenShell-Authorization, preserve application-owned credentials, and strip reserved gateway headers/cookies from both application paths.Release Notes
Breaking behavior: authenticated gateways now require gateway authentication for application requests with the app listener enabled or disabled. Direct app-listener authentication remains the ingress provider's responsibility. Browser users start login at the control-plane
/auth/services?service_origin=...endpoint.Testing
Operational semantics
Credential revocation affects subsequent application requests and upgrades across gateway replicas. Existing WebSockets retain authentication at upgrade; external IdP token revocation is subject to the gateway's offline verifier semantics unless the gateway application-revocation endpoint is used. These endpoints do not revoke control-plane RPC credentials or external IdP issuance.
Checklist
RFC 0017 draft stack: #4936 → #4940 → #4941 → #4956 → #4957 → #4958 → #4959. The example Kubernetes HTTPRoute controller remains on a separate branch outside this stack.