fix(helm): validate gateway listener ports - #3179
Open
guanchzhou wants to merge 2 commits into
Open
Conversation
Reject disabled required listeners, out-of-range values, and port collisions before Kubernetes accepts an unusable gateway workload. Signed-off-by: Andrey Maltsev <maltsev.andrey@gmail.com>
guanchzhou
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 4, 2026 08:40
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. |
Author
|
recheck |
Validate raw listener port values before integer conversion so booleans and fractional numbers cannot bypass range and collision checks. Signed-off-by: Andrey Maltsev <maltsev.andrey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject invalid gateway listener port values during Helm rendering, before Kubernetes admission or gateway startup.
Related Issue
No issue required: this is localized chart validation for configurations the gateway already cannot run.
Changes
0as disabled and validate enabled metrics portsTesting
mise run pre-commitpasseshelm unittest deploy/helm/openshell(133 tests)helm unittest deploy/helm/openshell-workspace(4 tests)Checklist