fix(gpu): select single CDI GPU defaults#1675
Draft
elezar wants to merge 1 commit into
Draft
Conversation
7 tasks
|
🌿 Preview your docs: https://nvidia-preview-pr-1675.docs.buildwithfern.com/openshell |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
de229a4 to
7fa3cc6
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #1156 to implement Docker and Podman CDI GPU selection for
resource_requirements.gpu.Default GPU requests select one concrete NVIDIA CDI device. Count requests select
countconcrete devices. Explicitdevice_idspass through unchanged.Related Issue
Closes #1477
Blocked by #1156.
Changes
DiscoveredDevices./dev/nvidiaNdevices to CDI IDs.Testing
cargo check -p openshell-core -p openshell-cli -p openshell-server -p openshell-driver-kubernetes -p openshell-driver-docker -p openshell-driver-podman -p openshell-driver-vm --testscargo test -p openshell-core -p openshell-cli -p openshell-server -p openshell-driver-kubernetes -p openshell-driver-docker -p openshell-driver-podman -p openshell-driver-vm gpu --testsmise run pre-commitChecklist