Skip to content

Document copy-PR testing authorization - #2423

Merged
kevalmorabia97 merged 3 commits into
mainfrom
docs/copy-pr-testing
Sep 13, 2026
Merged

kevalmorabia97 merged 3 commits into
mainfrom
docs/copy-pr-testing

Conversation

@realAsma

@realAsma realAsma commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Type of change: documentation.

Explain how authorized vetters start NVIDIA-runner checks for pull requests from forks, including the SHA-qualified copy-PR command and links to the centralized contributor and vetter guidance.

Usage

N/A; documentation-only change.

Testing

  • pre-commit run --files CONTRIBUTING.md
  • git diff --check
  • Verified both copy-PR documentation links resolve

Before your PR is "Ready for review"

  • Is this change backward compatible?: N/A
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A
  • Did you write any new necessary tests?: N/A
  • Did you update CHANGELOG.rst?: N/A
  • Did you get Claude approval on this PR?: N/A

Additional Information

Clarifies the missing required-check state encountered on #2231.

Summary by CodeRabbit

  • Documentation
    • Updated fork pull-request guidance to require an authorized reviewer’s approval before NVIDIA-hosted CI runs.
    • Added instructions for contributors without write access to obtain GitHub workflow approval from a reviewer with write permission.
    • Added the /ok to test <full-head-sha> command for authorizing testing against a specific commit.

Signed-off-by: realAsma <akuriparambi@nvidia.com>
@realAsma
realAsma requested a review from a team as a code owner September 13, 2026 14:14
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 38a82869-825d-4900-ae37-d263ad304b7b

📥 Commits

Reviewing files that changed from the base of the PR and between 5c3560d and 998d040.

📒 Files selected for processing (1)
  • CONTRIBUTING.md

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

The contributor guide updates fork pull-request instructions for NVIDIA-hosted CI. It requires authorized-vetter approval with the full head SHA and workflow approval for contributors without write access.

Changes

Fork Pull Request Validation

Layer / File(s) Summary
Fork pull request validation guidance
CONTRIBUTING.md
Updates fork pull-request instructions to require an authorized vetter’s /ok to test <full-head-sha> comment for NVIDIA-hosted CI. Adds workflow approval steps for contributors without write access.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 998d0

This documentation-only update is ready to merge; normal documentation checks are sufficient.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the documentation change that authorizes copy-PR testing for fork pull requests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Anti-Patterns ✅ Passed PASS. The reviewed range changes only CONTRIBUTING.md (+3 lines). It contains workflow documentation and no modelopt or examples Python changes, dependency manifest changes, or added security-sensit…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/copy-pr-testing

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.41%. Comparing base (51de53e) to head (998d040).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2423      +/-   ##
==========================================
+ Coverage   71.39%   71.41%   +0.01%     
==========================================
  Files         590      590              
  Lines       64646    65089     +443     
==========================================
+ Hits        46154    46482     +328     
- Misses      18492    18607     +115     
Flag Coverage Δ
unit 57.80% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: realAsma <akuriparambi@nvidia.com>
Signed-off-by: realAsma <akuriparambi@nvidia.com>
@kevalmorabia97
kevalmorabia97 merged commit 700e188 into main Sep 13, 2026
31 checks passed
@kevalmorabia97
kevalmorabia97 deleted the docs/copy-pr-testing branch September 13, 2026 16:38
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-13 16:38 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants