-
Notifications
You must be signed in to change notification settings - Fork 599
[5565357] Fix SDXL NVFP4 export and performance #2336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ajrasane
wants to merge
11
commits into
main
Choose a base branch
from
arasane/fix_sdxl_nvfp4_export
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ccece7f
[5565357] Fix SDXL NVFP4 export and performance
ajrasane 320d4bb
[5565357] Simplify SDXL NVFP4 recipe
ajrasane e9d9e6d
[5565357] Address Diffusers FP4 review feedback
ajrasane 373eebd
[5565357] Fix Diffusers FP8 export handling
ajrasane 56e3279
[5565357] Preserve restored Diffusers quantization policy
ajrasane 4c63f68
[5565357] Simplify SDXL NVFP4 implementation
ajrasane cb7fc32
[5565357] Preserve FP8 custom-op shapes
ajrasane 7161de6
[5565357] Simplify Diffusers quantized export
ajrasane 034fe23
[5565357] Complete FP8 export follow-up
ajrasane 4f18eaa
[5565357] Document shared ONNX export changes
ajrasane 3a9f61e
Merge main into SDXL NVFP4 export branch
ajrasane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
modelopt_recipes/configs/ptq/presets/diffusers/nvfp4_fp8_conv.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # Diffusers SDXL preset with dynamic NVFP4 Linears and per-tensor FP8 Conv2d layers. | ||
|
|
||
| # modelopt-schema: modelopt.torch.quantization.config.QuantizeConfig | ||
| imports: | ||
| base_disable_all: configs/ptq/units/base_disable_all | ||
| fp8: configs/numerics/fp8 | ||
| nvfp4: configs/numerics/nvfp4 | ||
|
|
||
| algorithm: max | ||
| quant_cfg: | ||
| - $import: base_disable_all | ||
| - parent_class: nn.Linear | ||
| quantizer_name: '*weight_quantizer' | ||
| cfg: | ||
| $import: nvfp4 | ||
| - parent_class: nn.Linear | ||
| quantizer_name: '*input_quantizer' | ||
| cfg: | ||
| $import: nvfp4 | ||
| - parent_class: nn.Linear | ||
| quantizer_name: '*to_[qkv].input_quantizer' | ||
| enable: false | ||
| - parent_class: nn.Linear | ||
| quantizer_name: '*to_[qkv].weight_quantizer' | ||
| enable: false | ||
| - parent_class: nn.Conv2d | ||
| quantizer_name: '*weight_quantizer' | ||
| cfg: | ||
| $import: fp8 | ||
| - parent_class: nn.Conv2d | ||
| quantizer_name: '*input_quantizer' | ||
| cfg: | ||
| $import: fp8 | ||
| - quantizer_name: '*output_quantizer' | ||
| enable: false | ||
| - quantizer_name: '*softmax_quantizer' | ||
| cfg: | ||
| $import: fp8 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This drops
convert_zp_fp8+ the gs cleanup/toposort for every non-Flux FP8 export (SDXL, SD3, LTX, Wan), not just SDXL FP4. The WAR pairing (generate_fp8_scalesforcing INT8 QDQ, then rewriting zero points back to FP8) is only safe to remove if_fp8_quantizenow emitsTRT_FP8QuantizeLinearfor Conv in all these models. The new CPU test covers a barenn.Conv2d; please confirm an end-to-end FP8 SDXL export still builds in TRT and note the removal in the PR body.