Make group-boundary AutoQuant scoring the default#1988
Conversation
Score gradient perturbations at parent attention and MLP outputs by default, with an explicit local-boundary opt-out and local-only KL-divergence behavior. Signed-off-by: weimingc <17592131+meenchen@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1988 +/- ##
==========================================
+ Coverage 77.40% 77.45% +0.05%
==========================================
Files 524 524
Lines 59267 59479 +212
==========================================
+ Hits 45873 46070 +197
- Misses 13394 13409 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What does this PR do?
Type of change: New feature
AutoQuant gradient scoring currently measures each quantized projection at its leaf output. That can understate perturbations that are amplified by the surrounding attention or MoE computation.
This PR:
score_boundary: local;This branch intentionally contains only group-boundary scoring. Per-element score normalization remains a separate change.
Usage
To restore the previous leaf-output behavior:
Testing
test_autoquant.py,test_loader.py, andtest_hf_ptq_args.py.test_data_parallel_auto_quantize.261291782b717182859cf2f87b37830315e4c8746a300a5general/auto_quantize/nvfp4_fp8_at_5p4bitsCOMPLETED, exit0:0Before your PR is "Ready for review"
score_boundary: localrestores the previous behavior.CONTRIBUTING.md: N/AAdditional Information
The scoring boundary is distinct from module grouping: this PR changes where sensitivity is measured, not which modules share one AutoQuant assignment.