Repository navigation
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe LeRobot example now has Hatch project metadata with Python version constraints, runtime dependencies, an optional visualization extra, and namespace-preserving wheel settings. The README documents editable Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to New recordings cannot be opened by the visualizer without manually relocating or renaming the dataset. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (3 skipped: 3 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
45a4b4c to
fcac985
Compare
fcac985 to
ec63e91
Compare
ec63e91 to
45e4ec3
Compare
45e4ec3 to
6098702
Compare
6098702 to
fba88c9
Compare
|
Same as #1038: Needs a root |
fba88c9 to
875ea87
Compare
875ea87 to
b9dffa7
Compare
b9dffa7 to
ee68ef3
Compare
ee68ef3 to
0a3f91a
Compare
0a3f91a to
77f8958
Compare
77f8958 to
3bcb697
Compare
3bcb697 to
2ff1827
Compare
5081917 to
865236c
Compare
e2fced0 to
6e50643
Compare
6e50643 to
a768588
Compare
a768588 to
ed2a9b7
Compare
ed2a9b7 to
1e6561e
Compare
Package the LeRobot examples without claiming the upstream lerobot import name, and use one working-directory dataset location. Part of #985. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Keep recorded datasets out of version control when the installed example runs from the repository root. Part of #985. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Make the haptic examples installable and runnable with the shared example package convention. Part of #985. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Package the CloudXR MuJoCo examples with the assets their modules locate beside themselves. Part of #985. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
1e6561e to
991ea66
Compare
|
examples(lerobot) is going to be removed. |
Description
Part of #985. Active stack: #1039 → #1040 → #1043 → #1046 → #1047.
Package LeRobot under
isaaccapture_examples.lerobotand keep dataset paths relative to the working directory. Preserves the haptic-feedback (#1044) and CloudXR MuJoCo (#1045) conversions already merged into this branch; those PRs are no longer separate stack entries. All three packages follow the Isaac Capture namespace and distribution names.Type of change
Testing
Full pre-commit, strict Sphinx build, and documentation-reference checks passed. Wheel layout and installed-package namespace checks cover all three packages, including the CloudXR meshes. Headset and recording runs were not exercised.
Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCO