Skip to content

examples(lerobot): package under isaaccapture_examples - #1043

Closed
jiwenc-nv wants to merge 4 commits into
jiwenc-nv/examples-camera-vizfrom
jiwenc-nv/examples-lerobot
Closed

jiwenc-nv wants to merge 4 commits into
jiwenc-nv/examples-camera-vizfrom
jiwenc-nv/examples-lerobot

Conversation

@jiwenc-nv

@jiwenc-nv jiwenc-nv commented Aug 28, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Part of #985. Active stack: #1039 → #1040 → #1043 → #1046 → #1047.

Package LeRobot under isaaccapture_examples.lerobot and keep dataset paths relative to the working directory. Preserves the haptic-feedback (#1044) and CloudXR MuJoCo (#1045) conversions already merged into this branch; those PRs are no longer separate stack entries. All three packages follow the Isaac Capture namespace and distribution names.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

Full pre-commit, strict Sphinx build, and documentation-reference checks passed. Wheel layout and installed-package namespace checks cover all three packages, including the CloudXR meshes. Headset and recording runs were not exercised.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

@coderabbitai

coderabbitai Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bc626e5c-79cc-494d-b93c-2584c7f2591b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The LeRobot example now has Hatch project metadata with Python version constraints, runtime dependencies, an optional visualization extra, and namespace-preserving wheel settings. The README documents editable uv installation, module usage, dataset handling, and the SO-101 example location. Recording now writes datasets to ./local_datasets/teleop_tracking_<timestamp>. Git ignores this directory. License headers were added to the package initializer.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to 50819

New recordings cannot be opened by the visualizer without manually relocating or renaming the dataset.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (3 skipped: 3 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ⚠️ Warning The title describes packaging the example under isaaccapture_examples, but the pull request packages it under isaacteleop_examples. Change the title to reference isaacteleop_examples, for example: examples(lerobot): package under isaacteleop_examples.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from 45a4b4c to fcac985 Compare August 28, 2026 05:01
@jiwenc-nv
jiwenc-nv changed the base branch from jiwenc-nv/examples-deviceio-live-view to jiwenc-nv/examples-oglo-tactile August 28, 2026 05:01
@jiwenc-nv
jiwenc-nv requested a review from ivany-nv August 28, 2026 05:11
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from fcac985 to ec63e91 Compare August 28, 2026 05:23
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from ec63e91 to 45e4ec3 Compare August 28, 2026 05:32
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from 45e4ec3 to 6098702 Compare August 28, 2026 05:44
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from 6098702 to fba88c9 Compare August 28, 2026 05:49
@ivany-nv

Copy link
Copy Markdown
Contributor

Same as #1038: Path(__file__).parent -> Path.cwd() / "local_datasets/..." is right for an installed copy, but examples/lerobot/.gitignore: local_datasets/ only covers the example directory, and the README says to run from the repo root:

$ git check-ignore -v local_datasets/x
(not ignored)

Needs a root .gitignore entry.

@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from fba88c9 to 875ea87 Compare August 28, 2026 14:46
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from 875ea87 to b9dffa7 Compare August 28, 2026 16:11
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from b9dffa7 to ee68ef3 Compare August 28, 2026 23:49
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from ee68ef3 to 0a3f91a Compare August 29, 2026 00:21
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from 0a3f91a to 77f8958 Compare August 29, 2026 01:19
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from 77f8958 to 3bcb697 Compare August 30, 2026 16:23
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from 3bcb697 to 2ff1827 Compare August 31, 2026 15:09
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from 5081917 to 865236c Compare September 18, 2026 16:02
Base automatically changed from jiwenc-nv/examples-oglo-tactile to jiwenc-nv/examples-camera-viz September 18, 2026 16:19
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch 2 times, most recently from e2fced0 to 6e50643 Compare September 18, 2026 17:19
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from 6e50643 to a768588 Compare September 18, 2026 17:34
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from a768588 to ed2a9b7 Compare September 18, 2026 21:16
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-lerobot branch from ed2a9b7 to 1e6561e Compare September 30, 2026 02:58
@jiwenc-nv
jiwenc-nv removed this pull request from stack #1048 September 30, 2026 03:01
@jiwenc-nv jiwenc-nv changed the title examples(lerobot): package under isaacteleop_examples examples(lerobot): package under isaaccapture_examples Sep 30, 2026
@jiwenc-nv
jiwenc-nv added this pull request to stack #1167 September 30, 2026 03:02
Package the LeRobot examples without claiming the upstream lerobot import name, and use one working-directory dataset location.

Part of #985.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Keep recorded datasets out of version control when the installed example runs from the repository root.

Part of #985.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Make the haptic examples installable and runnable with the shared example package convention.

Part of #985.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Package the CloudXR MuJoCo examples with the assets their modules locate beside themselves.

Part of #985.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
@ivany-nv

Copy link
Copy Markdown
Contributor

examples(lerobot) is going to be removed.

@ivany-nv ivany-nv closed this Oct 19, 2026
github-actions Bot added a commit that referenced this pull request Oct 19, 2026

This branch was successfully deployed

1 active deployment
dev — 991ea66d Deployed Sep 30, 2026 by jiwenc-nv via publish-wheel #5158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants