Skip to content

fix(gym): prefetch missing Super35 service environments - #4261

Merged
yfw merged 1 commit into
super-v3.5-posttrainingfrom
yifu/super35-prefetch-journey-envs
Sep 24, 2026
Merged

yfw merged 1 commit into
super-v3.5-posttrainingfrom
yifu/super35-prefetch-journey-envs

Conversation

@yfw

@yfw yfw commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Add the bundled SA-V tracks, citation instruction-following, conversational tool-use simulation, and structured-output v4 configs to the Super35 Gym prefetch config. Together they cover five previously missing service venvs:

  • resources_servers/sav_tracks
  • resources_servers/citation_if
  • resources_servers/conversational_tool_use_simulation
  • responses_api_agents/conversational_tool_use/simulation
  • responses_api_agents/non_executing_simple_agent

Without these entries, newer multimodal/MOPD recipes install the environments during job startup, which can contend on editable Gym builds and time out. Including them lets image builds pre-install the dependencies instead. Existing prefetch entries, dependency pins, and training configs are unchanged.

Add parametrized regression coverage that checks each service has a bundled entrypoint and that its source exists in the pinned Gym checkout.

Validation

  • Targeted prefetch tests: 15 passed, 3 skipped (existing local-vLLM checks require vLLM).
  • Confirmed all five new regression cases fail against the previous prefetch config.
  • Full Gym offline config resolution passes, including simulator_model inheritance and the nested simulation-agent venv path.
  • Ruff checks/formatting and git diff --check pass.
  • A full container rebuild was not run for this PR.

Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
@yfw
yfw requested review from a team as code owners September 24, 2026 19:48
@copy-pr-bot

copy-pr-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yfw
yfw merged commit eb420d1 into super-v3.5-posttraining Sep 24, 2026
10 checks passed
@yfw
yfw deleted the yifu/super35-prefetch-journey-envs branch September 24, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant