Skip to content

ci: AUT-1408 replace cicd PAT with GitHub App tokens - #2299

Open
svcnemo-autobot wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:ci/use-github-app-auth
Open

ci: AUT-1408 replace cicd PAT with GitHub App tokens#2299
svcnemo-autobot wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:ci/use-github-app-auth

Conversation

@svcnemo-autobot

Copy link
Copy Markdown
Contributor

Background

cicd-main passed the long-lived secrets.PAT credential into container-build and test actions.

What changed

Mint short-lived GitHub App tokens from vars.BOT_ID and secrets.BOT_KEY in both consuming jobs.

Details

flowchart LR
  ID[BOT_ID] --> Token[Mint app token]
  Key[BOT_KEY] --> Token
  Token --> Build[Container build]
  Token --> Tests[Test action]
Loading

The token action is pinned to immutable v3.2.0. Existing local action input names remain unchanged.

Tested

  • pre-commit run --files .github/workflows/cicd-main.yml --show-diff-on-failure --color=never
  • Workflow YAML parsing and per-job token-order assertions
  • Verified 2 token steps and zero secrets.PAT references
  • git diff --check

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot
svcnemo-autobot requested a review from a team as a code owner August 7, 2026 22:56
@copy-pr-bot

copy-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The workflow replaces a long-lived PAT with short-lived GitHub App tokens in the container-build and GPU-test jobs.

  • Adds a pinned actions/create-github-app-token step to each consuming job.
  • Sources App credentials from vars.BOT_ID and secrets.BOT_KEY.
  • Preserves the existing local-action PAT input interface while passing the generated token.

Confidence Score: 5/5

The PR appears safe to merge with no actionable failures identified in the changed workflow.

The generated tokens are created before both consuming steps, and the existing local-action input contracts remain intact; repository context shows those token inputs currently do not drive an operation requiring broader scope or a longer credential lifetime.

Important Files Changed

Filename Overview
.github/workflows/cicd-main.yml Replaces two PAT references with independently minted, short-lived GitHub App tokens; no actionable defect was identified.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  ID[vars.BOT_ID] --> BUILD_TOKEN[Mint build-job token]
  KEY[secrets.BOT_KEY] --> BUILD_TOKEN
  BUILD_TOKEN --> BUILD[build-container PAT input]
  ID --> TEST_TOKEN[Mint test-job token]
  KEY --> TEST_TOKEN
  TEST_TOKEN --> TEST[test-template PAT input]
Loading

Reviews (1): Last reviewed commit: "ci: AUT-1408 replace cicd PAT with GitHu..." | Re-trigger Greptile

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the gpuci Run GPU CI/CD on PR label Aug 7, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test a0d521e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gpuci Run GPU CI/CD on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants