ci: AUT-1408 replace cicd PAT with GitHub App tokens - #2299
Open
svcnemo-autobot wants to merge 1 commit into
Open
ci: AUT-1408 replace cicd PAT with GitHub App tokens#2299svcnemo-autobot wants to merge 1 commit into
svcnemo-autobot wants to merge 1 commit into
Conversation
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Contributor
Greptile SummaryThe workflow replaces a long-lived PAT with short-lived GitHub App tokens in the container-build and GPU-test jobs.
Confidence Score: 5/5The PR appears safe to merge with no actionable failures identified in the changed workflow. The generated tokens are created before both consuming steps, and the existing local-action input contracts remain intact; repository context shows those token inputs currently do not drive an operation requiring broader scope or a longer credential lifetime. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
ID[vars.BOT_ID] --> BUILD_TOKEN[Mint build-job token]
KEY[secrets.BOT_KEY] --> BUILD_TOKEN
BUILD_TOKEN --> BUILD[build-container PAT input]
ID --> TEST_TOKEN[Mint test-job token]
KEY --> TEST_TOKEN
TEST_TOKEN --> TEST[test-template PAT input]
Reviews (1): Last reviewed commit: "ci: AUT-1408 replace cicd PAT with GitHu..." | Re-trigger Greptile |
Contributor
|
/ok to test a0d521e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
cicd-mainpassed the long-livedsecrets.PATcredential into container-build and test actions.What changed
Mint short-lived GitHub App tokens from
vars.BOT_IDandsecrets.BOT_KEYin both consuming jobs.Details
The token action is pinned to immutable v3.2.0. Existing local action input names remain unchanged.
Tested
pre-commit run --files .github/workflows/cicd-main.yml --show-diff-on-failure --color=neversecrets.PATreferencesgit diff --check