Skip to content

🎨 Palette: Improve keyboard accessibility for script list rows - #148

Open
NSEvent wants to merge 2 commits into
mainfrom
palette/fix-script-list-tap-accessibility-15905202632032209405
Open

🎨 Palette: Improve keyboard accessibility for script list rows#148
NSEvent wants to merge 2 commits into
mainfrom
palette/fix-script-list-tap-accessibility-15905202632032209405

Conversation

@NSEvent

@NSEvent NSEvent commented Aug 20, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced .onTapGesture with a Button utilizing .buttonStyle(.plain) for ScriptRow list items, keeping .contentShape(Rectangle()) inside the label to maintain the expected tap targets.
🎯 Why: .onTapGesture on layout containers (HStack) works for mouse clicks but natively lacks keyboard focus support or proper trait identification for VoiceOver users.
♿ Accessibility: The row is now correctly navigable and actionable using the keyboard or a screen reader.


PR created automatically by Jules for task 15905202632032209405 started by @NSEvent

Replaces `.onTapGesture` with a plain `Button` wrapper for `ScriptRow` items in `ScriptListView.swift`, ensuring proper keyboard interactivity and screen reader focus support while preserving the clickable area shape.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@NSEvent, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2d99c90b-6858-4f6a-b326-21845b494a38

📥 Commits

Reviewing files that changed from the base of the PR and between 491237a and 730237f.

📒 Files selected for processing (2)
  • .Jules/palette.md
  • XboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Replaces `.onTapGesture` with a plain `Button` wrapper for `ScriptRow` items in `ScriptListView.swift`, ensuring proper keyboard interactivity and screen reader focus support while preserving the clickable area shape.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant