🛡️ Sentinel: [CRITICAL] Fix Denial of Service (Deadlock) in AutomationExecutor - #147
🛡️ Sentinel: [CRITICAL] Fix Denial of Service (Deadlock) in AutomationExecutor#147NSEvent wants to merge 4 commits into
Conversation
This commit addresses a critical DoS vulnerability where the `runProcess` and `childPIDs` functions in `AutomationExecutor` waited for the process to exit (`waitUntilExit`) before draining the output pipe buffer (`readDataToEndOfFile`). If a child process emitted more than the OS pipe buffer limit (~64KB), the child would block waiting for the parent to read, while the parent was blocked on `waitUntilExit`, causing a deadlock. The operations have been reordered to read the data first. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 25 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesAutomationExecutor pipe handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change reorders process-output handling to prevent pipe-buffer deadlocks; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… tests This commit addresses a critical DoS vulnerability where the `runProcess` and `childPIDs` functions in `AutomationExecutor` waited for the process to exit (`waitUntilExit`) before draining the output pipe buffer (`readDataToEndOfFile`). It also fixes a similar issue in the `OBSWebSocketLiveIntegrationTests.swift` file. If a child process emitted more than the OS pipe buffer limit (~64KB), the child would block waiting for the parent to read, while the parent was blocked on `waitUntilExit`, causing a deadlock. The operations have been reordered to read the data first. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
… tests This commit addresses a critical DoS vulnerability where the `runProcess` and `childPIDs` functions in `AutomationExecutor` waited for the process to exit (`waitUntilExit`) before draining the output pipe buffer (`readDataToEndOfFile`). It also fixes a similar issue in the `OBSWebSocketLiveIntegrationTests.swift` file. If a child process emitted more than the OS pipe buffer limit (~64KB), the child would block waiting for the parent to read, while the parent was blocked on `waitUntilExit`, causing a deadlock. The operations have been reordered to read the data first. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
… tests This commit addresses a critical DoS vulnerability where the `runProcess` and `childPIDs` functions in `AutomationExecutor` waited for the process to exit (`waitUntilExit`) before draining the output pipe buffer (`readDataToEndOfFile`). It also fixes a similar issue in the `OBSWebSocketLiveIntegrationTests.swift` file. If a child process emitted more than the OS pipe buffer limit (~64KB), the child would block waiting for the parent to read, while the parent was blocked on `waitUntilExit`, causing a deadlock. The operations have been reordered to read the data first. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
Fix Denial of Service via Pipe Deadlock in AutomationExecutor
This commit addresses a critical DoS vulnerability where the
runProcessandchildPIDsfunctions inAutomationExecutorwaited for the process to exit (waitUntilExit) before draining the output pipe buffer (readDataToEndOfFile).If a child process emitted more than the OS pipe buffer limit (~64KB), the child would block waiting for the parent to read, while the parent was blocked on
waitUntilExit, causing a deadlock.The operations have been reordered to read the data first.
PR created automatically by Jules for task 11252634361850743819 started by @NSEvent
Summary by CodeRabbit