🎨 Palette: Replace onTapGesture with accessible list item Buttons - #138
🎨 Palette: Replace onTapGesture with accessible list item Buttons#138NSEvent wants to merge 1 commit into
Conversation
Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 51 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: The UX enhancement added:
Replaced
.onTapGestureon list items inMacroListViewandScriptListViewwith semanticButtonelements that use.buttonStyle(.plain).🎯 Why: The user problem it solves:
Using
.onTapGestureprevents elements from receiving keyboard focus and native VoiceOver navigation. Wrapping these list items inButtons restores proper keyboard interactivity (Space/Enter to trigger) and provides much better context for screen readers.📸 Before/After: Visual appearance remains exactly identical thanks to
.buttonStyle(.plain).♿ Accessibility: Added explicit
.accessibilityLabelinterpolation containing the item's name or a fallback (e.g., "Untitled Script") so VoiceOver users hear a helpful description instead of "Button".PR created automatically by Jules for task 12900312138030392251 started by @NSEvent