Repository navigation
setup_env.sh: report the venv's Python when reusing a venv (#53) - #113
Merged
Merged
Conversation
The script printed the interpreter discovery picked, then reused an existing .venv built by a different one, so 'python: 3.10' could sit above a test run on 3.11. Reusing a venv now names the venv's own version and warns when it differs, and the test step names the interpreter it runs on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53.
When reusing an existing
.venv,setup_env.shprinted the interpreter its discovery loop picked, not the one actually in the venv. So its output could claim the tests ran on 3.10 when they ran on 3.11.reusing .venv (Python 3.11.5).note: differs from discovered Python 3.12.7; delete .venv to rebuild with it.The issue's second point, the README's "3.11 or newer" claim, is already fixed on
main.Verification:
bash -npasses. I ran the venv block against a 3.11 venv with 3.12 and 3.11 as the discovered interpreter: the warning appears only for the mismatch.🤖 Generated with Claude Code