Repository navigation
M1: state contigs and genome length at the top of genome (#71) - #112
Merged
Merged
Conversation
Both routes already read the values but kept them only under genome.quality, while the full report looked for a top-level genome.contigs and so never showed it. genome.contigs and genome.genome_length are now top-level integers on the CGA and API routes, declared in the schema, and the report falls back to the quality block for runs written before this. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71.
Both M1 routes already read
contigsandgenome_length, but kept them only undergenome.quality. The full report looks for a top-levelgenome.contigs, so its Contigs stat never appeared.genome.contigsandgenome.genome_lengthare now top-level integers on both the CGA route (parse.genome_section) and the API route (collect.genome_section). Thequalitycopies are kept.genomeschema as integer or null. They are optional, soSCHEMA_VERSIONis unchanged and existing fixtures still validate.qualityfor runs written before this change.Tests: two new tests cover both routes, schema validation and the fallback. The full suite passes: 475 tests. I also checked end to end: an M1 run from
fixtures/m1/cga_samplewritescontigs: 1andgenome_length: 580076, andfull_report.htmlshows both.🤖 Generated with Claude Code