Skip to content

M1: state contigs and genome length at the top of genome (#71) - #112

Merged
Jiahuic merged 2 commits into
mainfrom
fix/71-genome-size
Nov 17, 2026
Merged

Jiahuic merged 2 commits into
mainfrom
fix/71-genome-size

Conversation

@Jiahuic

@Jiahuic Jiahuic commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Closes #71.

Both M1 routes already read contigs and genome_length, but kept them only under genome.quality. The full report looks for a top-level genome.contigs, so its Contigs stat never appeared.

  • genome.contigs and genome.genome_length are now top-level integers on both the CGA route (parse.genome_section) and the API route (collect.genome_section). The quality copies are kept.
  • Both keys are declared in the genome schema as integer or null. They are optional, so SCHEMA_VERSION is unchanged and existing fixtures still validate.
  • The full report reads the top-level keys and falls back to quality for runs written before this change.

Tests: two new tests cover both routes, schema validation and the fallback. The full suite passes: 475 tests. I also checked end to end: an M1 run from fixtures/m1/cga_sample writes contigs: 1 and genome_length: 580076, and full_report.html shows both.

🤖 Generated with Claude Code

Jiahuic and others added 2 commits November 17, 2026 12:19
Both routes already read the values but kept them only under
genome.quality, while the full report looked for a top-level
genome.contigs and so never showed it. genome.contigs and
genome.genome_length are now top-level integers on the CGA and API
routes, declared in the schema, and the report falls back to the quality
block for runs written before this.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Jiahuic
Jiahuic merged commit f2655ec into main Nov 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

M1: the genome section carries no contig count or genome length

1 participant