Repository navigation
Runner: a dry run names no file it did not write (#70) - #111
Merged
Merged
Conversation
--dry-run printed 'done. report: <run>/report.json' and created the run directory, though it ran no stage. It now creates nothing and ends with 'dry run: N stage(s) listed, nothing run, nothing written.' Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70.
python -m s2f.run ... --dry-runused to printdone. report: runs/x/report.jsonfor a file it never wrote, and it also created an empty run directory.Now a dry run:
dry run: N stage(s) listed, nothing run, nothing written.Tests: one new test in
tests/test_run.pyasserts the run directory does not exist after a dry run and that the output never mentionsreport.json. The full suite passes.🤖 Generated with Claude Code