Skip to content

Runner: a dry run names no file it did not write (#70) - #111

Merged
Jiahuic merged 2 commits into
mainfrom
fix/70-dry-run-report-line
Nov 17, 2026
Merged

Jiahuic merged 2 commits into
mainfrom
fix/70-dry-run-report-line

Conversation

@Jiahuic

@Jiahuic Jiahuic commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Closes #70.

python -m s2f.run ... --dry-run used to print done. report: runs/x/report.json for a file it never wrote, and it also created an empty run directory.

Now a dry run:

  • prints each stage's command, as before
  • creates nothing, not even the run directory
  • ends with dry run: N stage(s) listed, nothing run, nothing written.

Tests: one new test in tests/test_run.py asserts the run directory does not exist after a dry run and that the output never mentions report.json. The full suite passes.

🤖 Generated with Claude Code

Jiahuic and others added 2 commits November 17, 2026 12:18
--dry-run printed 'done. report: <run>/report.json' and created the run
directory, though it ran no stage. It now creates nothing and ends with
'dry run: N stage(s) listed, nothing run, nothing written.'

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Jiahuic
Jiahuic merged commit ad93ab4 into main Nov 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runner: --dry-run reports a report.json it never writes

1 participant