Skip to content

M2: count failed PDB searches instead of hiding them (#69) - #110

Merged
Jiahuic merged 2 commits into
mainfrom
fix/69-failed-search-count
Nov 17, 2026
Merged

Jiahuic merged 2 commits into
mainfrom
fix/69-failed-search-count

Conversation

@Jiahuic

@Jiahuic Jiahuic commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Closes #69.

A query-failed protein landed in neither the hit nor the miss bucket, so a cold offline run printed 0 without a PDB hit next to a warning that every search failed.

I kept the documented rule that a failed query is never recorded as an absence of hits, so no_pdb_hit is unchanged. Failures are now counted on their own:

  • counts.pdb_search_failed in run.json
  • m2_pdb/pdb_search_failed.tsv, alongside no_pdb_hit.tsv, which had the same blind spot
  • the summary line, for example 4 proteins scored from 3 unique sequences; 3 selected, 0 without a PDB hit, 4 not known (PDB search failed).
  • the warning now gives both the number of failed searches (unique sequences) and the number of proteins they cover

Tests: two new tests in tests/test_m2_dry_run.py cover the all-failed run (dry-run with an empty cache) and the clean run. The full suite passes: 475 tests.

🤖 Generated with Claude Code

Jiahuic and others added 2 commits November 17, 2026 12:17
A protein whose search failed is neither a hit nor a miss, so it fell out
of both counts and an all-failed offline run reported '0 without a PDB
hit'. It now has its own counts.pdb_search_failed, its own
pdb_search_failed.tsv, and the summary line names it. no_pdb_hit keeps
its meaning: a failed query is never recorded as an absence of hits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Jiahuic
Jiahuic merged commit 9685347 into main Nov 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

M2: counts.no_pdb_hit does not count a failed search as a miss

1 participant