Repository navigation
M2: count failed PDB searches instead of hiding them (#69) - #110
Merged
Merged
Conversation
A protein whose search failed is neither a hit nor a miss, so it fell out of both counts and an all-failed offline run reported '0 without a PDB hit'. It now has its own counts.pdb_search_failed, its own pdb_search_failed.tsv, and the summary line names it. no_pdb_hit keeps its meaning: a failed query is never recorded as an absence of hits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69.
A
query-failedprotein landed in neither the hit nor the miss bucket, so a cold offline run printed0 without a PDB hitnext to a warning that every search failed.I kept the documented rule that a failed query is never recorded as an absence of hits, so
no_pdb_hitis unchanged. Failures are now counted on their own:counts.pdb_search_failedinrun.jsonm2_pdb/pdb_search_failed.tsv, alongsideno_pdb_hit.tsv, which had the same blind spot4 proteins scored from 3 unique sequences; 3 selected, 0 without a PDB hit, 4 not known (PDB search failed).Tests: two new tests in
tests/test_m2_dry_run.pycover the all-failed run (dry-run with an empty cache) and the clean run. The full suite passes: 475 tests.🤖 Generated with Claude Code